This repository was archived by the owner on Oct 18, 2024. It is now read-only.
fix: rename files asynchronously #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit resolves the freeze that occurs when renaming a large file.
MrIkso reviewed Nov 9, 2023
app/src/main/java/com/itsaky/androidide/actions/filetree/RenameAction.kt Outdated Show resolved Hide resolved
itsaky suggested changes Nov 10, 2023
There was a problem hiding this comment.
As the file renaming is performed asynchronously, it should show a progress bar to the user. You can use helper functions from coroutineUtils.kt.
app/src/main/java/com/itsaky/androidide/actions/filetree/RenameAction.kt Outdated Show resolved Hide resolved
itsaky suggested changes Nov 10, 2023
app/src/main/java/com/itsaky/androidide/actions/filetree/RenameAction.kt Outdated Show resolved Hide resolved
itsaky approved these changes Nov 10, 2023
| Thank you for your contributions. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.