This repository was archived by the owner on Oct 18, 2024. It is now read-only.
[Feature] Replace ic_close with ic_sweep_delete on the "Clear logs" FAB #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…he FAB for clearing logs
itsaky approved these changes Oct 26, 2023
itsaky pushed a commit that referenced this pull request Nov 9, 2023
…he FAB for clearing logs (#1404)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request replaces ic_close with ic_sweep_delete on the floating action button inside the editor bottom sheet.
🖼️ Comparison before / after
This new icon delivers the meaning of this button better. The old one might be interpreted as "Close bottom sheet" or "Cancel current task" for example.