Skip to content
This repository was archived by the owner on Oct 18, 2024. It is now read-only.

Commit 2cf9012

Browse files
committed
build(conf): core app config is not applied to :core:app module
1 parent 5d6c833 commit 2cf9012

File tree

5 files changed

+15
-5
lines changed

5 files changed

+15
-5
lines changed

composite-builds/build-logic/plugins/build.gradle.kts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ gradlePlugin {
5252
id = "com.itsaky.androidide.build"
5353
implementationClass = "com.itsaky.androidide.plugins.AndroidIDEPlugin"
5454
}
55+
create("com.itsaky.androidide.core-app") {
56+
id = "com.itsaky.androidide.core-app"
57+
implementationClass = "com.itsaky.androidide.plugins.AndroidIDECoreAppPlugin"
58+
}
5559
create("com.itsaky.androidide.build.propsparser") {
5660
id = "com.itsaky.androidide.build.propsparser"
5761
implementationClass = "com.itsaky.androidide.plugins.PropertiesParserPlugin"

composite-builds/build-logic/plugins/src/main/java/com/itsaky/androidide/plugins/AndroidIDEPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class AndroidIDEPlugin : Plugin<Project> {
4848
plugins.apply(SigningConfigPlugin::class.java)
4949
}
5050

51-
if (isFDroidBuild && project.plugins.hasPlugin(AndroidIDECoreAppPlugin::class.java)) {
51+
if (isFDroidBuild && project.plugins.hasPlugin("com.itsaky.androidide.core-app")) {
5252
val baseExtension = extensions.getByType(BaseExtension::class.java)
5353
logger.warn("Building for F-Droid with configuration:")
5454
logger.warn("applicationId = ${baseExtension.defaultConfig.applicationId}")

composite-builds/build-logic/plugins/src/main/java/com/itsaky/androidide/plugins/DIConfigPlugin.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717

1818
package com.itsaky.androidide.plugins
1919

20+
import com.itsaky.androidide.plugins.util.isAndroidModule
2021
import org.gradle.api.Plugin
2122
import org.gradle.api.Project
23+
import org.gradle.api.artifacts.VersionCatalogsExtension
2224

2325
/**
2426
* Configures dependency injection in a module.
@@ -29,6 +31,12 @@ class DIConfigPlugin : Plugin<Project> {
2931

3032
override fun apply(target: Project) = target.run {
3133
dependencies.add("implementation", "javax.inject:javax.inject:1")
34+
if (isAndroidModule) {
35+
val libs =
36+
rootProject.extensions.getByType(VersionCatalogsExtension::class.java).named("libs")
37+
val hiltAndroid = libs.findLibrary("hilt-android").get().get()
38+
dependencies.add("implementation", hiltAndroid)
39+
}
3240
Unit
3341
}
3442
}

composite-builds/build-logic/plugins/src/main/java/com/itsaky/androidide/plugins/conf/AndroidModuleConf.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import com.itsaky.androidide.build.config.BuildConfig
2727
import com.itsaky.androidide.build.config.FDroidConfig
2828
import com.itsaky.androidide.build.config.isFDroidBuild
2929
import com.itsaky.androidide.build.config.projectVersionCode
30-
import com.itsaky.androidide.plugins.AndroidIDECoreAppPlugin
3130
import com.itsaky.androidide.plugins.NoDesugarPlugin
3231
import com.itsaky.androidide.plugins.util.SdkUtils.getAndroidJar
3332
import org.gradle.api.Project
@@ -119,7 +118,7 @@ fun Project.configureAndroidModule(
119118

120119
configureCoreLibDesugaring(this, coreLibDesugDep)
121120

122-
if (project.plugins.hasPlugin(AndroidIDECoreAppPlugin::class.java)) {
121+
if (project.plugins.hasPlugin("com.itsaky.androidide.core-app")) {
123122
packagingOptions {
124123
jniLibs {
125124
useLegacyPackaging = true

core/app/build.gradle.kts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
import com.itsaky.androidide.build.config.BuildConfig
44
import com.itsaky.androidide.desugaring.utils.JavaIOReplacements.applyJavaIOReplacements
55
import com.itsaky.androidide.plugins.AndroidIDEAssetsPlugin
6-
import com.itsaky.androidide.plugins.AndroidIDECoreAppPlugin
76

87
plugins {
8+
id("com.itsaky.androidide.core-app")
99
id("com.android.application")
1010
id("kotlin-android")
1111
id("kotlin-kapt")
@@ -18,7 +18,6 @@ plugins {
1818

1919
apply {
2020
plugin(AndroidIDEAssetsPlugin::class.java)
21-
plugin(AndroidIDECoreAppPlugin::class.java)
2221
}
2322

2423
buildscript {

0 commit comments

Comments
 (0)