Skip to content

Commit 0ee9844

Browse files
update
1 parent b317e2f commit 0ee9844

File tree

2 files changed

+18
-32
lines changed

2 files changed

+18
-32
lines changed

apps/cli/src/helpers/core/env-setup.ts

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -292,13 +292,8 @@ export async function setupEnvironmentVariables(config: ProjectConfig) {
292292
siteUrlComments += "# npx convex env set SITE_URL http://localhost:3001\n";
293293
}
294294
if (hasNative) {
295-
if (hasWeb) {
296-
siteUrlComments +=
297-
"# npx convex env set NATIVE_SITE_URL http://localhost:8081 # For Expo Web\n";
298-
} else {
299-
siteUrlComments +=
300-
"# npx convex env set SITE_URL http://localhost:8081 # For Expo Web\n";
301-
}
295+
siteUrlComments +=
296+
"# npx convex env set NATIVE_SITE_URL http://localhost:8081 # For Expo Web\n";
302297
}
303298
const convexCommands = `# Set Convex environment variables
304299
# npx convex env set BETTER_AUTH_SECRET=$(openssl rand -base64 32)
@@ -309,27 +304,20 @@ ${siteUrlComments}`;
309304
const convexBackendVars: EnvVariable[] = [];
310305

311306
if (hasNative) {
312-
convexBackendVars.push({
313-
key: "EXPO_PUBLIC_CONVEX_SITE_URL",
314-
value: "",
315-
condition: true,
316-
comment: "Same as CONVEX_URL but ends in .site",
317-
});
318-
if (hasWeb) {
319-
convexBackendVars.push({
307+
convexBackendVars.push(
308+
{
309+
key: "EXPO_PUBLIC_CONVEX_SITE_URL",
310+
value: "",
311+
condition: true,
312+
comment: "Same as CONVEX_URL but ends in .site",
313+
},
314+
{
320315
key: "NATIVE_SITE_URL",
321316
value: "http://localhost:8081",
322317
condition: true,
323318
comment: "Expo Web URL for authentication",
324-
});
325-
} else {
326-
convexBackendVars.push({
327-
key: "SITE_URL",
328-
value: "http://localhost:8081",
329-
condition: true,
330-
comment: "Required for Expo Web support",
331-
});
332-
}
319+
},
320+
);
333321
}
334322

335323
if (hasWeb) {

apps/cli/templates/auth/better-auth/convex/backend/convex/auth.ts.hbs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,14 @@ import { betterAuth } from "better-auth";
1414
import { v } from "convex/values";
1515
import authConfig from "./auth.config";
1616

17-
{{#if (or (includes frontend "tanstack-start") (includes frontend "next") (includes frontend "tanstack-router") (includes frontend "react-router") (includes frontend "nuxt") (includes frontend "svelte") (includes frontend "solid"))}}
17+
{{#if (or (includes frontend "tanstack-start") (includes frontend "next"))}}
18+
const siteUrl = process.env.SITE_URL!;
19+
{{else if (or (includes frontend "tanstack-router") (includes frontend "react-router") (includes frontend "nuxt") (includes frontend "svelte") (includes frontend "solid"))}}
1820
const siteUrl = process.env.SITE_URL!;
1921
{{/if}}
2022
{{#if (or (includes frontend "native-bare") (includes frontend "native-uniwind") (includes frontend "native-unistyles"))}}
2123
const nativeAppUrl = process.env.NATIVE_APP_URL || "mybettertapp://";
22-
{{#if (or (includes frontend "tanstack-start") (includes frontend "next") (includes frontend "tanstack-router") (includes frontend "react-router") (includes frontend "nuxt") (includes frontend "svelte") (includes frontend "solid"))}}
2324
const nativeSiteUrl = process.env.NATIVE_SITE_URL || "http://localhost:8081";
24-
{{else}}
25-
const siteUrl = process.env.SITE_URL || "http://localhost:8081";
26-
{{/if}}
2725
{{/if}}
2826

2927
export const authComponent = createClient<DataModel>(components.betterAuth);
@@ -36,11 +34,11 @@ function createAuth(ctx: GenericCtx<DataModel>) {
3634
{{else if (and (or (includes frontend "native-bare") (includes frontend "native-uniwind") (includes frontend "native-unistyles")) (or (includes frontend "tanstack-router") (includes frontend "react-router") (includes frontend "nuxt") (includes frontend "svelte") (includes frontend "solid")))}}
3735
trustedOrigins: [siteUrl, nativeSiteUrl, nativeAppUrl],
3836
{{else if (or (includes frontend "native-bare") (includes frontend "native-uniwind") (includes frontend "native-unistyles"))}}
39-
trustedOrigins: [siteUrl, nativeAppUrl],
37+
trustedOrigins: [nativeSiteUrl, nativeAppUrl],
4038
{{else if (or (includes frontend "tanstack-start") (includes frontend "next"))}}
4139
baseURL: siteUrl,
4240
trustedOrigins: [siteUrl],
43-
{{else}}
41+
{{else if (or (includes frontend "tanstack-router") (includes frontend "react-router") (includes frontend "nuxt") (includes frontend "svelte") (includes frontend "solid"))}}
4442
trustedOrigins: [siteUrl],
4543
{{/if}}
4644
database: authComponent.adapter(ctx),
@@ -51,7 +49,7 @@ function createAuth(ctx: GenericCtx<DataModel>) {
5149
plugins: [
5250
{{#if (or (includes frontend "native-bare") (includes frontend "native-uniwind") (includes frontend "native-unistyles"))}}
5351
expo(),
54-
crossDomain({ siteUrl }),
52+
crossDomain({ siteUrl: nativeSiteUrl }),
5553
{{else if (or (includes frontend "tanstack-router") (includes frontend "react-router") (includes frontend "nuxt") (includes frontend "svelte") (includes frontend "solid"))}}
5654
crossDomain({ siteUrl }),
5755
{{/if}}

0 commit comments

Comments
 (0)