Change ordering

Author: Alexmg86

README.md

@@ -98,9 +98,9 @@ or with conditions
 ```php
 $invoices = Invoice::orderByRelation(['items:price' => function (Builder $query) {
  $query->where('price', '>', 6);
-}, 'max', 'desc'])->get();
+}, 'desc', 'max'])->get();
 ```
 By default, sorting is by `max` and `desc`, you can choose one of the options `max`, `min`, `sum`, `avg`, `desc`, `acs`.
 ```php
-$invoices = Invoice::orderByRelation('items:price', 'sum', 'asc')->get();
+$invoices = Invoice::orderByRelation('items:price', 'asc', 'sum')->get();
 ```

src/LaravelSubQuery.php

@@ -59,14 +59,16 @@ public function withAvg($relations)
  return $this->withSubQuery($relations, 'avg');
  }
 
- public function orderByRelation($relations, $type = 'max', $orderType = 'desc')
+ public function orderByRelation($relations, $orderType = 'desc', $type = 'max')
  {
  if (is_array($relations)) {
- $type = $relations[0];
- $orderType = $relations[1];
+ $orderType = $relations[0];
+ $type = $relations[1];
  unset($relations[0], $relations[1]);
  }
-
+ if (!strpos($relations, ':')) {
+ return $this->orderBy($relations, $orderType);
+ }
  return $this->withSubQuery($relations, $type, $orderType);
  }