Making the Subscribers use a common base class- now with failing test case

Author: bbakerman

src/test/java/org/dataloader/DataLoaderBatchPublisherTest.java

@@ -385,18 +385,20 @@ public void should_Resolve_to_error_to_indicate_failure() throws ExecutionExcept
  DataLoader<Integer, Object> evenLoader = idLoaderOddEvenExceptions(new DataLoaderOptions(), loadCalls);
 
  CompletableFuture<Object> future1 = evenLoader.load(1);
- evenLoader.dispatch();
+ CompletableFuture<List<Object>> dispatchCF = evenLoader.dispatch();
 
  await().until(future1::isDone);
  assertThat(future1.isCompletedExceptionally(), is(true));
  assertThat(cause(future1), instanceOf(IllegalStateException.class));
+ assertThat(dispatchCF.isCompletedExceptionally(), is(true));
 
  CompletableFuture<Object> future2 = evenLoader.load(2);
- evenLoader.dispatch();
+ dispatchCF = evenLoader.dispatch();
 
  await().until(future2::isDone);
  assertThat(future2.get(), equalTo(2));
  assertThat(loadCalls, equalTo(asList(singletonList(1), singletonList(2))));
+ assertThat(dispatchCF.isCompletedExceptionally(), is(true));
  }
 
  // Accept any kind of key.

src/test/java/org/dataloader/DataLoaderMappedBatchPublisherTest.java

@@ -116,7 +116,7 @@ public void should_Propagate_error_to_all_loads() {
 
  CompletableFuture<Integer> future1 = errorLoader.load(1);
  CompletableFuture<Integer> future2 = errorLoader.load(2);
- errorLoader.dispatch();
+ CompletableFuture<List<Integer>> dispatchedCF = errorLoader.dispatch();
 
  await().until(future1::isDone);
 
@@ -132,6 +132,8 @@ public void should_Propagate_error_to_all_loads() {
  assertThat(cause.getMessage(), equalTo(cause.getMessage()));
 
  assertThat(loadCalls, equalTo(singletonList(asList(1, 2))));
+
+ assertThat(dispatchedCF.isCompletedExceptionally(),equalTo(true));
  }
 
  @Test