Skip to content

Commit 87e18fe

Browse files
committed
fix(ios): sometimes switches were not aligned correctly
1 parent 2f92889 commit 87e18fe

File tree

7 files changed

+10
-7
lines changed

7 files changed

+10
-7
lines changed

app/components/settings/FolderImageSyncSettings.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@
329329
</Template>
330330
<Template key="switch" let:item>
331331
<ListItemAutoSize fontSize={20} leftIcon={item.icon} subtitle={getDescription(item)} title={getTitle(item)} on:tap={(event) => onTap(item, event)}>
332-
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} on:checkedChange={(e) => onCheckBox(item, e)} />
332+
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} verticalAlignment="center" on:checkedChange={(e) => onCheckBox(item, e)} />
333333
</ListItemAutoSize>
334334
</Template>
335335
<Template let:item>

app/components/settings/FolderPDFSyncSettings.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@
346346
</Template>
347347
<Template key="switch" let:item>
348348
<ListItemAutoSize leftIcon={item.icon} subtitle={getDescription(item)} title={getTitle(item)} on:tap={(event) => onTap(item, event)}>
349-
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} on:checkedChange={(e) => onCheckBox(item, e)} />
349+
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} verticalAlignment="center" on:checkedChange={(e) => onCheckBox(item, e)} />
350350
</ListItemAutoSize>
351351
</Template>
352352
<Template key="pdfoptions" let:item>

app/components/settings/Settings.svelte

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
const dataSettingsAvailable = __ANDROID__ && android.os.Environment.getExternalStorageState() === 'mounted';
104104
105105
export let title = null;
106+
export let id = 'settingsPage';
106107
export let actionBarButtons = [
107108
{ icon: 'mdi-message-alert', id: 'feedback' },
108109
{ icon: 'mdi-share-variant', id: 'share' },
@@ -963,6 +964,7 @@
963964
case 'sub_settings': {
964965
showSettings({
965966
title: item.title,
967+
id: `settings[${item.id}]`,
966968
options: item.options(),
967969
actionBarButtons: item.actionBarButtons?.() || []
968970
});
@@ -1464,7 +1466,7 @@
14641466
onThemeChanged(refreshCollectionView);
14651467
</script>
14661468

1467-
<page bind:this={page} id="syncSettingsPage" actionBarHidden={true}>
1469+
<page bind:this={page} {id} actionBarHidden={true}>
14681470
<gridlayout class="pageContent" rows="auto,*">
14691471
<collectionview bind:this={collectionView} accessibilityValue="settingsCV" itemTemplateSelector={selectTemplate} {items} row={1} android:paddingBottom={$windowInset.bottom}>
14701472
<Template key="header" let:item>
@@ -1515,7 +1517,7 @@
15151517
</Template>
15161518
<Template key="switch" let:item>
15171519
<ListItemAutoSize subtitle={getDescription(item)} title={getTitle(item)} on:tap={(event) => onTap(item, event)}>
1518-
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} marginTop={16} verticalAlignment="top" on:checkedChange={(e) => onCheckBox(item, e)} />
1520+
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} marginTop={16} verticalAlignment="center" on:checkedChange={(e) => onCheckBox(item, e)} />
15191521
</ListItemAutoSize>
15201522
</Template>
15211523
<Template key="checkbox" let:item>

app/components/settings/SyncListSettings.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@
341341
}
342342
</script>
343343

344-
<page id="settingsPage" actionBarHidden={true}>
344+
<page id="syncSettingsPage" actionBarHidden={true}>
345345
<gridlayout class="pageContent" rows="auto,*">
346346
<collectionview bind:this={collectionView} itemTemplateSelector={selectTemplate} {items} row={1} android:paddingBottom={$windowInset.bottom}>
347347
<Template let:item>

app/components/settings/WebdavDataSyncSettings.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
checked={$store.enabled}
8787
col={1}
8888
marginLeft={10}
89+
verticalAlignment="center"
8990
on:checkedChange={(e) =>
9091
onCheckBox(e, (e) => {
9192
$store.enabled = e.value;

app/components/settings/WebdavImageSyncSettings.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@
359359
</Template>
360360
<Template key="switch" let:item>
361361
<ListItemAutoSize fontSize={20} leftIcon={item.icon} subtitle={getDescription(item)} title={getTitle(item)} on:tap={(event) => onTap(item, event)}>
362-
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} on:checkedChange={(e) => onCheckBox(item, e)} />
362+
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} verticalAlignment="center" on:checkedChange={(e) => onCheckBox(item, e)} />
363363
</ListItemAutoSize>
364364
</Template>
365365
<Template let:item>

app/components/settings/WebdavPDFSyncSettings.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@
357357
</Template>
358358
<Template key="switch" let:item>
359359
<ListItemAutoSize fontSize={20} leftIcon={item.icon} subtitle={getDescription(item)} title={getTitle(item)} on:tap={(event) => onTap(item, event)}>
360-
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} on:checkedChange={(e) => onCheckBox(item, e)} />
360+
<switch id="checkbox" checked={item.value} col={1} marginLeft={10} verticalAlignment="center" on:checkedChange={(e) => onCheckBox(item, e)} />
361361
</ListItemAutoSize>
362362
</Template>
363363
<Template let:item>

0 commit comments

Comments
 (0)