add keyboard aware support to FlatList #148
Conversation
| render: function () { | ||
| return ( | ||
| <FlatList | ||
| ref='_rnkasv_keyboardView' |
There was a problem hiding this comment.
We should use callback refs instead of string refs.
There was a problem hiding this comment.
strings are used in the existing KeyboardAwareScrollView and KeyboardAwareListView components. KeyboardAwareMixin also references ref as this.refs._rnkasv_keyboardView, which I think should be this._rnkasv_keyboardView for callback refs. Do you want me to update everywhere to use callback refs in this PR? Or, leave it as is, and open another PR to switch to callback refs?
There was a problem hiding this comment.
@alvaromb How do you think about @chrisy-lili 's suggestion? We could have another PR for refs change.
| @chrisy-lili Would you like to update this PR for Android Support? Check |
| @Swordsman-Inaction I've updated the PR with android support based on your changes in the other component. Thanks for pointing me to that update. This PR is ready for review again :) |
| @alvaromb Can you review this again? I think we can change string refs later. It's ready to release a new version after merging this PR. |
| @Swordsman-Inaction done! Are we ready to release? |
| @alvaromb Yes! 👏 |
| what's the status on this? pls also ensure support for when the FlatList has the '''inverted''' prop enabled (expected behavior is that the scroll event will travel in the reverse or opposite direction) this would be a very common use case for chat-based apps |
| It's ready, but I'm still changing some things before releasing it. See this: #163 |
| Is there an example to show how to use KeyboardAwareFlatList? It always reponses that this.refs._rnkasv_keyboardView.getScrollResponder is not a function. |
| It's |
6 participants
No description provided.