chore(cleanup): code cleanup and eslint ignore

Author: jonluca

eslint.config.mjs

@@ -5,6 +5,7 @@ import prettierExtends from "eslint-config-prettier";
 import { fixupPluginRules } from "@eslint/compat";
 import globals from "globals";
 import tseslint from "typescript-eslint";
+import promisePlugin from "eslint-plugin-promise";
 
 const globalToUse = {
  ...globals.browser,
@@ -14,64 +15,64 @@ const globalToUse = {
  ...globals.node,
 };
 
-export default tseslint.config({
- extends: [
- {
- ignores: [
- "client/cypress/plugins/index.js",
- ".lintstagedrc.js",
- ".next/**/*",
- "public/js/*",
- ".yarn/js/*",
- "ui/out/**/*",
- "apps/expo/ios/**/*",
- "apps/expo/android/**/*",
- "electron/build/**/*",
- "public/*.js",
- "public/*.map",
+const ignores = [
+ ".lintstagedrc.js",
+ "**/.yarn/**/*",
+ "**/dist/**/*",
+ "public/js/*",
+ ".yarn/js/*",
+ "dist/**/*",
+ "coverage/**/*",
+];
+/** @type {import('@typescript-eslint/utils').FlatConfig.ConfigArray} */
+const configs = tseslint.config(
+ {
+ ignores,
+
+ extends: [
+ eslint.configs.recommended,
+ ...tseslint.configs.recommended,
+ promisePlugin.configs["flat/recommended"],
+ prettierExtends,
+ ],
+ plugins: {
+ promise: promisePlugin,
+ prettierPlugin,
+ "unused-imports": fixupPluginRules(unusedImportsPlugin),
+ },
+ rules: {
+ "prefer-rest-params": "off",
+ "prefer-const": "error",
+ "prefer-spread": "off",
+ "no-case-declarations": "off",
+ curly: ["error", "all"],
+ "@typescript-eslint/no-non-null-assertion": "off",
+ "@typescript-eslint/consistent-type-definitions": ["error", "interface"],
+ "@typescript-eslint/consistent-type-imports": [
+ "error",
+ {
+ prefer: "type-imports",
+ },
  ],
+ "@typescript-eslint/ban-ts-comment": "off",
+ "@typescript-eslint/no-explicit-any": "off",
+ "@typescript-eslint/no-use-before-define": ["off"],
+ "object-shorthand": "error",
+ "@typescript-eslint/no-unused-vars": [
+ "warn",
+ { varsIgnorePattern: "^_", argsIgnorePattern: "^_", ignoreRestSiblings: true },
+ ],
+ "unused-imports/no-unused-imports": "error",
  },
- prettierExtends,
- eslint.configs.recommended,
- ...tseslint.configs.recommended,
- ],
- settings: {
- react: { version: "detect" },
- },
- plugins: {
- prettierPlugin,
- "unused-imports": fixupPluginRules(unusedImportsPlugin),
- },
- rules: {
- "prefer-rest-params": "off",
- "prefer-const": "error",
- "prefer-spread": "off",
- "no-case-declarations": "off",
- curly: ["error", "all"],
- "@typescript-eslint/no-non-null-assertion": "off",
- "@typescript-eslint/consistent-type-definitions": ["error", "interface"],
- "@typescript-eslint/consistent-type-imports": [
- "error",
- {
- prefer: "type-imports",
- },
- ],
- "@typescript-eslint/ban-ts-comment": "off",
- "@typescript-eslint/no-explicit-any": "off",
- "@typescript-eslint/no-use-before-define": ["off"],
- "object-shorthand": "error",
- "@typescript-eslint/no-unused-vars": [
- "warn",
- { varsIgnorePattern: "^_", argsIgnorePattern: "^_", ignoreRestSiblings: true },
- ],
- "unused-imports/no-unused-imports": "error",
- },
- languageOptions: {
- globals: globalToUse,
- parserOptions: {
- ecmaFeatures: {
- jsx: true,
+ languageOptions: {
+ globals: globalToUse,
+ parserOptions: {
+ ecmaFeatures: {
+ jsx: true,
+ },
  },
  },
  },
-});
+ { ignores },
+);
+export default configs;

lib/pointer.ts

@@ -104,7 +104,7 @@ class Pointer<S extends object = JSONSchema, O extends ParserOptions<S> = Parser
  }
 
  const token = tokens[i];
- 
+
  if (this.value[token] === undefined || (this.value[token] === null && i === tokens.length - 1)) {
  // one final case is if the entry itself includes slashes, and was parsed out as a token - we can join the remaining tokens and try again
  let didFindSubstringSlashMatch = false;
@@ -123,22 +123,18 @@ class Pointer<S extends object = JSONSchema, O extends ParserOptions<S> = Parser
 
  this.value = null;
 
- let path: any = '';
+ const path = this.$ref.path || "";
 
- if (path !== undefined) {
-  path = this.$ref.path;
- }
+ const targetRef = this.path.replace(path, "");
+ const targetFound = Pointer.join("", found);
+ const parentPath = pathFromRoot?.replace(path, "");
 
- const targetRef = this.path.replace(path, '');
- const targetFound = Pointer.join('', found);
- const parentPath = pathFromRoot?.replace(path, '');
- 
  throw new MissingPointerError(token, decodeURI(this.originalPath), targetRef, targetFound, parentPath);
  } else {
  this.value = this.value[token];
  }
 
- found.push(token)
+ found.push(token);
  }
 
  // Resolve the final value

test/specs/empty/empty.spec.ts

@@ -10,7 +10,7 @@ describe("Empty schema", () => {
  const parser = new $RefParser();
  const schema = await parser.parse(path.rel("test/specs/empty/empty.json"));
  expect(schema).to.be.an("object");
- expect(schema).to.be.empty; // eslint-disable-line no-unused-expressions
+ expect(schema).to.be.empty;  
  expect(parser.schema).to.equal(schema);
  expect(parser.$refs.paths()).to.deep.equal([path.abs("test/specs/empty/empty.json")]);
  });
@@ -24,7 +24,7 @@ describe("Empty schema", () => {
  const parser = new $RefParser();
  const schema = await parser.dereference(path.rel("test/specs/empty/empty.json"));
  expect(schema).to.be.an("object");
- expect(schema).to.be.empty; // eslint-disable-line no-unused-expressions
+ expect(schema).to.be.empty;  
  expect(parser.schema).to.equal(schema);
  expect(parser.$refs.paths()).to.deep.equal([path.abs("test/specs/empty/empty.json")]);
  // The "circular" flag should NOT be set
@@ -35,7 +35,7 @@ describe("Empty schema", () => {
  const parser = new $RefParser();
  const schema = await parser.bundle(path.rel("test/specs/empty/empty.json"));
  expect(schema).to.be.an("object");
- expect(schema).to.be.empty; // eslint-disable-line no-unused-expressions
+ expect(schema).to.be.empty;  
  expect(parser.schema).to.equal(schema);
  expect(parser.$refs.paths()).to.deep.equal([path.abs("test/specs/empty/empty.json")]);
  });

test/specs/http.spec.ts

@@ -155,7 +155,7 @@ describe("HTTP options", () => {
  const schema = await parser.parse("https://petstore.swagger.io/v2/swagger.json");
 
  expect(schema).to.be.an("object");
- expect(schema).not.to.be.empty; // eslint-disable-line no-unused-expressions
+ expect(schema).not.to.be.empty;  
  expect(parser.schema).to.equal(schema);
  });
 
@@ -170,7 +170,7 @@ describe("HTTP options", () => {
  });
 
  expect(schema).to.be.an("object");
- expect(schema).not.to.be.empty; // eslint-disable-line no-unused-expressions
+ expect(schema).not.to.be.empty;  
  expect(parser.schema).to.equal(schema);
  });
 
@@ -188,7 +188,7 @@ describe("HTTP options", () => {
 
  // The request succeeded, which means this browser doesn't support CORS.
  expect(schema).to.be.an("object");
- expect(schema).not.to.be.empty; // eslint-disable-line no-unused-expressions
+ expect(schema).not.to.be.empty;  
  expect(parser.schema).to.equal(schema);
  } catch (err) {
  // The request failed, which is expected

test/specs/refs.spec.ts

@@ -134,7 +134,7 @@ describe("$Refs object", () => {
  values = $refs.values();
  expect(values).to.deep.equal(expected);
  } else {
- expect(values).to.be.an("object").and.empty; // eslint-disable-line no-unused-expressions
+ expect(values).to.be.an("object").and.empty;  
  }
  });
 
@@ -154,7 +154,7 @@ describe("$Refs object", () => {
  values = $refs.values();
  expect(values).to.deep.equal(expected);
  } else {
- expect(values).to.be.an("object").and.empty; // eslint-disable-line no-unused-expressions
+ expect(values).to.be.an("object").and.empty;  
  }
  });
  });