fix(server): fix POST request forward to routes defined in after option

Fix a bug introduced in cee700d where the serveIndex feature where always replying instead of forwarding requests to the next middleware.

Author: jvasseur

lib/Server.js

@@ -390,13 +390,25 @@ class Server {
 
  if (Array.isArray(contentBase)) {
  contentBase.forEach((item) => {
- this.app.use(contentBasePublicPath, serveIndex(item));
+ this.app.use(contentBasePublicPath, (req, res, next) => {
+ if (req.method !== 'GET') {
+ return next();
+ }
+
+ serveIndex(item)(req, res, next);
+ });
  });
  } else if (
  typeof contentBase !== 'number' &&
  !isAbsoluteUrl(String(contentBase))
  ) {
- this.app.use(contentBasePublicPath, serveIndex(contentBase));
+ this.app.use(contentBasePublicPath, (req, res, next) => {
+ if (req.method !== 'GET') {
+ return next();
+ }
+
+ serveIndex(contentBase)(req, res, next);
+ });
  }
  }
 

test/server/after-option.test.js

@@ -29,6 +29,10 @@ describe('after option', () => {
  appArg.get('/after/some/path', (_, response) => {
  response.send('after');
  });
+
+ appArg.post('/after/some/path', (_, response) => {
+ response.send('after POST');
+ });
  },
  port,
  },
@@ -48,4 +52,14 @@ describe('after option', () => {
  expect(response.text).toBe('after');
  });
  });
+
+ it('should handle POST requests to after route', () => {
+ return req
+ .post('/after/some/path')
+ .expect('Content-Type', 'text/html; charset=utf-8')
+ .expect(200)
+ .then((response) => {
+ expect(response.text).toBe('after POST');
+ });
+ });
 });

test/server/contentBasePublicPath-option.test.js

@@ -277,19 +277,19 @@ describe('contentBasePublicPath option', () => {
  });
 
  it('POST request', (done) => {
- req.post(`${contentBasePublicPath}/`).expect(405, done);
+ req.post(`${contentBasePublicPath}/`).expect(404, done);
  });
 
  it('PUT request', (done) => {
- req.put(`${contentBasePublicPath}/`).expect(405, done);
+ req.put(`${contentBasePublicPath}/`).expect(404, done);
  });
 
  it('DELETE request', (done) => {
- req.delete(`${contentBasePublicPath}/`).expect(405, done);
+ req.delete(`${contentBasePublicPath}/`).expect(404, done);
  });
 
  it('PATCH request', (done) => {
- req.patch(`${contentBasePublicPath}/`).expect(405, done);
+ req.patch(`${contentBasePublicPath}/`).expect(404, done);
  });
  });
 });