Skip to content

Conversation

@snitin315
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

Deps upgrade. Update jest to v29

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 97.34% // Head: 97.34% // No change to project coverage 👍

Coverage data is based on head (61ad21d) compared to base (e7e3f56).
Patch has no changes to coverable lines.

Additional details and impacted files
@@ Coverage Diff @@ ## master #1390 +/- ## ======================================= Coverage 97.34% 97.34% ======================================= Files 9 9 Lines 377 377 Branches 112 112 ======================================= Hits 367 367 Misses 9 9 Partials 1 1 

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait
Copy link
Member

@snitin315 Need rebase 👍

@snitin315
Copy link
Member Author

@alexander-akait Done. Any other breaking change we want to do for this package? Migrate to ESM?

@alexander-akait
Copy link
Member

@snitin315 Do we resolve all TODO? If yes, I will do release 👍

@snitin315
Copy link
Member Author

@alexander-akait only one TODO is left, but I see it is for webpack and not this package.

// TODO: improve that in future
// For example - `writeToDisk` can throw an error and right now it is ends watching.
// We can improve that and keep watching active, but it is require API on webpack side.
// Let's implement that in webpack@5 because it is rare case.
context.logger.error(error);

@alexander-akait
Copy link
Member

alexander-akait commented Nov 20, 2022

@snitin315 it requires some changes on webpack side, so let's postpone it, also noone ask about this improve in our bug tackers so it is not priority

@alexander-akait alexander-akait merged commit 03f2d24 into master Nov 20, 2022
@alexander-akait alexander-akait deleted the update-jest branch November 20, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants