This repository was archived by the owner on Jan 18, 2022. It is now read-only.
[plugin-next] Fix Rollup when no template in an SFC #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @elevatebart Yes, removing it seems to work as I tried manually but I don't know if it's really correct or not in the new Vue 3 (maybe we are missing something..) |
jtommy reviewed Sep 16, 2020
src/index.ts Outdated
| isServer | ||
| ) | ||
| | ||
| const templateImport = descriptor.template |
There was a problem hiding this comment.
The right condition is !descriptor.template
jtommy suggested changes Sep 16, 2020
| @@ -0,0 +1,10 @@ | |||
| <script> | |||
| import h from 'vue' | |||
There was a problem hiding this comment.
h isnt' the default export, you should use import { h } from 'vue'
znck approved these changes Oct 20, 2020
| Some edge cases that may be related to vuejs/core#2463 |
| I am troubled by this question. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
SFCs can have a script block only
In this case, the render function should not be replaced by the empty template function.
It should be left alone.
/ping @znck @jtommy