Skip to content

[fix] export CompileOptions #7658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dummdidumm merged 3 commits into from
Jul 6, 2022
Merged

[fix] export CompileOptions #7658

dummdidumm merged 3 commits into from
Jul 6, 2022

Conversation

@dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 5, 2022 •
edited
Loading

It's used by SvelteKit and in order to properly use it under the new TS moduleResolution NodeNext it needs to be part of a file that is defined in the exports map

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint
Simon added 2 commits July 5, 2022 19:10
[fix] export CompileOptions
d0e46e0 
It's are used by SvelteKit and in order to properly use it under the new TS moduleResolution NodeNext it needs to be part of a file that is defined in the exports map
ok I lied about running the linter locally
7c74bc7
benmccann
benmccann reviewed Jul 5, 2022
View reviewed changes
@dummdidumm @benmccann
Update src/compiler/index.ts
6a100db 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@dummdidumm dummdidumm merged commit 0fa0a38 into sveltejs:master Jul 6, 2022
@dummdidumm dummdidumm deleted the export-compile-options branch July 6, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dummdidumm @benmccann @bluwy