Move everything out of lib.rs into their own modules #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
# Conflicts: # src/lib.rs
maltesander added a commit to stackabletech/spark-operator that referenced this pull request Mar 5, 2021
maltesander added a commit to stackabletech/spark-operator that referenced this pull request Mar 9, 2021
* Adapted to operator-rs changes * Updated and working with operator-rs (stackabletech/operator-rs#77)
maltesander added a commit to stackabletech/spark-operator that referenced this pull request Mar 9, 2021
* Adapted to operator-rs changes * Updated and working with operator-rs (stackabletech/operator-rs#77) * Added pod_utils for pod related methods. Adjusted get_master_urls in preparation to add to pod labels to keep track in worker pods which masters are known (in case masters change / scale / delete etc.) * Added pod_utils for pod operations * Added comments, renamed parameters * Only write master_url_hash into worker nodes * Workers are restarted in a rolling fashion if masters are added / deleted * Added spark.port.maxRetries configuration property * removed clippy warning * Adapted to PR reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are no code changes in here, purely movement of code and the imports