added apply_patch_status method using Merge strategy #64
Conversation
src/client.rs Outdated
| /// This is supported on crate feature jsonpatch only | ||
| /// 3) Merge (https://tools.ietf.org/html/rfc7386): | ||
| /// For example, if you want to update a list you have to specify the complete list and update everything | ||
| /// 4) Strategic |
There was a problem hiding this comment.
Maybe add a note that strategic merge is not available for custom resources
src/client.rs Outdated
| S: Serialize, | ||
| { | ||
| let new_status = Patch::Merge(serde_json::json!({ | ||
| "apiVersion": T::API_VERSION, |
There was a problem hiding this comment.
Is this really necessary?
The docs of the patch_status method doesn't have it.
There was a problem hiding this comment.
You mean apiVersion? Yes. Without using spark operator:
source: KubeError { source: Api(ErrorResponse { status: "Failure", message: "Incorrect version specified in apply patch. Specified patch version: , expected: spark.stackable.tech/v1", reason: "BadRequest", code: 400
…tatus for the individual strategies based on non public patch_status.
| Could you merge/fix the conflict? It's probably my documentation :( |
# Conflicts: # src/client.rs
src/client.rs Outdated
| "apiVersion": T::API_VERSION, | ||
| "kind": T::KIND, |
There was a problem hiding this comment.
I'm 99% certain that these two are only required for the apply patch but they don't seem to hurt either....
There was a problem hiding this comment.
Yes just tested you were right. Removed it! One last commit :)
No description provided.