misc: update wheel building and release scripts #9570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 3 commits October 9, 2020 14:10
CI now builds the pure Python wheel and sdist. Use the Github API to pull down all assets associated with the CI build. Because this script now does very little, it's a lot simpler. Since it's no longer building things, I assume we can be less picky about what Python we use. The version check now runs against the sdist, which is nice.
download-mypyc-wheels is now subsumed by upload-pypi, which uses the Github API instead of hardcoding filenames. test_installed_version is part of mypyc_mypy-wheels and some of what it does is taken care of by cibuildwheel
msullivan approved these changes Oct 18, 2020
Collaborator
msullivan left a comment
msullivan left a comment There was a problem hiding this comment.
This seems pretty reasonable to me and we should move forward with it. We should coordinate merging it so I can bother you about any "fine-tuning" that needs to be done.
Closed
ilevkivskyi pushed a commit that referenced this pull request Jan 19, 2021
* new upload pypi script CI now builds the pure Python wheel and sdist. Use the Github API to pull down all assets associated with the CI build. Because this script now does very little, it's a lot simpler. Since it's no longer building things, I assume we can be less picky about what Python we use. The version check now runs against the sdist, which is nice. * update trigger wheel build for new wheel building * remove more scripts download-mypyc-wheels is now subsumed by upload-pypi, which uses the Github API instead of hardcoding filenames. test_installed_version is part of mypyc_mypy-wheels and some of what it does is taken care of by cibuildwheel * fix repo :-) Co-authored-by: hauntsaninja <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This goes together with mypyc/mypy_mypyc-wheels#11 to resolve #9536
download-mypyc-wheels is now subsumed by upload-pypi, which uses the Github API instead of hardcoding filenames. This also means you won't need to make changes like #9559 If this feels fragile, let me know and I can add back a check against a hardcoded list of names (note CI won't make a release if one of the builds fails).
test_installed_version is part of mypyc_mypy-wheels and some of what it does is taken care of by cibuildwheel
upload-pypi can be made a lot simpler, since CI now builds the pure Python wheel and sdist. Since it's no longer building things, I assume we can be less picky about what Python we use. The version check now runs against the sdist, which is nice.
Some of this was a little hard to test end to end, but if there are kinks it shouldn't be too hard to work them out.