Update wheel download script to use the correct file names for macOS #9559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We switched the macOS version in the mypy_mypyc-wheels repository for Python 3.6 and 3.7 wheels. Examples of wheel names: https://github.com/mypyc/mypy_mypyc-wheels/releases/tag/v0.790%2Bdev.7273e9ab1664b59a74d9bd1d2361bbeb9864b7ab
ilevkivskyi approved these changes Oct 8, 2020
JukkaL added a commit that referenced this pull request Oct 8, 2020
…9559) We switched the macOS version in the mypy_mypyc-wheels repository for Python 3.6 and 3.7 wheels. Examples of wheel names: https://github.com/mypyc/mypy_mypyc-wheels/releases/tag/v0.790%2Bdev.7273e9ab1664b59a74d9bd1d2361bbeb9864b7ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We switched the macOS version in the mypy_mypyc-wheels repository
for Python 3.6 and 3.7 wheels.
Examples of wheel names:
https://github.com/mypyc/mypy_mypyc-wheels/releases/tag/v0.790%2Bdev.7273e9ab1664b59a74d9bd1d2361bbeb9864b7ab
The motivation for the original change was to avoid building anything
32-bit, since that's not tested and not officially supported anyway. If
this change causes problems, we should be able to switch this back,
but let's see how this goes.