Refactor apiClientImpl.DoGetFallback #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Make apiClientImpl.DoGetFallback more idiomatic and efficient: * Save result of args.Encode() operation as it might be used 2 times in the function and due to looping and sorting it might be heavy. * Follow line-of-sight practise and therefore simplify the code. Signed-off-by: Tomáš Dohnálek <dohnto@gmail.com>
dohnto force-pushed the dohnto/line-of-sight branch from 4bf68a2 to 40e54a7 Compare 
dohnto commented Apr 7, 2022
kakkoyun approved these changes Apr 12, 2022
Member
kakkoyun left a comment
kakkoyun left a comment There was a problem hiding this comment.
LGTM 👍 Thanks for the contribution.
I'll go ahead and merge it since we have tests for this method and there doesn't seem to any regressions present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make apiClientImpl.DoGetFallback more idiomatic and efficient:
the function and due to looping and sorting it might be heavy.