GetBoolean might be called on a decimal #707
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The following test (and 1 more) currently fails in Pomelo.MySql:
https://github.com/aspnet/EntityFrameworkCore/blob/817aaea6ca1a24a29e8e9f3a7b2dd3748956d942/test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs#L1503-L1519
It gets translated to:
It seems that
COALESCE
is returning adecimal
forIsAutomatic
, though the column is actually of typebit(1)
. The code expects abool
and callsGetBoolean
, which then throws.This fix allows the explicit conversion from
decimal
tobool
withinRow.GetBoolean()
.This is not critical, so we don't need a quick release for this.