Apply request_headers_override to websocket requests #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for submitting your first pull request! You are awesome! 🤗 |
sk1p added a commit to sk1p/LiberTEM-jupyter-proxy that referenced this pull request Aug 17, 2021
Note that this depends on jupyterhub/jupyter-server-proxy#287 to be merged, otherwise websocket connections will fail.
This was referenced Aug 17, 2021
sk1p added a commit to LiberTEM/LiberTEM-jupyter-proxy that referenced this pull request Aug 19, 2021
Note that this depends on jupyterhub/jupyter-server-proxy#287 to be merged, otherwise websocket connections will fail.
| Congrats on your first merged pull request in this project! 🎉 |
| Thank you very much for the PR and the detailed tests, @sk1p! I really appreciate the effort you've put into making this easy to review and merge |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #286