[Fix] no-unknown-property: make onLoad and onError be accepted on more elements

Author: sjarva

CHANGELOG.md

@@ -12,6 +12,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 * [`no-unknown-property`]: move allowfullscreen to case ignored attributes ([#3390][] @sjarva)
 * [`no-unknown-property`]: fill works on line, mask, and use elements ([#3390][] @sjarva)
 * [`no-unknown-property`]: add onMouseMoveCapture as valid react-specific attribute ([#3390][] @sjarva)
+* [`no-unknown-property`]: make onLoad and onError be accepted on more elements ([#3390][] @sjarva)
 
 [#3390]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3390
 [#3388]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3388

lib/rules/no-unknown-property.js

@@ -66,8 +66,8 @@ const ATTRIBUTE_TAGS_MAP = {
  onEmptied: ['audio', 'video'],
  onEncrypted: ['audio', 'video'],
  onEnded: ['audio', 'video'],
- onError: ['audio', 'video', 'img', 'script'],
- onLoad: ['script', 'img'],
+ onError: ['audio', 'video', 'img', 'link', 'source', 'script'],
+ onLoad: ['script', 'img', 'link'],
  onLoadedData: ['audio', 'video'],
  onLoadedMetadata: ['audio', 'video'],
  onLoadStart: ['audio', 'video'],

tests/lib/rules/no-unknown-property.js

@@ -60,6 +60,8 @@ ruleTester.run('no-unknown-property', rule, {
  { code: '<video playsInline />' },
  { code: '<img onError={foo} onLoad={bar} />' },
  { code: '<script onLoad={bar} onError={foo} />' },
+ { code: '<source onError={foo} />' },
+ { code: '<link onLoad={bar} onError={foo} />' },
  {
  code: '<div allowTransparency="true" />',
  settings: {
@@ -389,7 +391,20 @@ ruleTester.run('no-unknown-property', rule, {
  data: {
  name: 'onError',
  tagName: 'div',
- allowedTags: 'audio, video, img, script',
+ allowedTags: 'audio, video, img, link, source, script',
+ },
+ },
+ ],
+ },
+ {
+ code: '<div onLoad={this.load} />',
+ errors: [
+ {
+ messageId: 'invalidPropOnTag',
+ data: {
+ name: 'onLoad',
+ tagName: 'div',
+ allowedTags: 'script, img, link',
  },
  },
  ],