Expose client connection types without proto feature #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
benesch force-pushed the connectors-no-proto branch 3 times, most recently from 056166b to 8a002cc Compare 
seanmonstar reviewed Dec 28, 2020
Member
seanmonstar left a comment
seanmonstar left a comment There was a problem hiding this comment.
Thanks so much for working on this! Just a couple thoughts inline.
| /// | ||
| /// This is returned by `Client::request` (and `Client::get`). | ||
| #[must_use = "futures do nothing unless polled"] | ||
| pub struct ResponseFuture { |
Member
There was a problem hiding this comment.
This type needs to still be accessible at hyper::client::ResponseFuture, to prevent a breaking change.
Contributor Author
There was a problem hiding this comment.
Eep! Great catch. Fixed!
Member
There was a problem hiding this comment.
Did you push the fix? I can't seem to see it...
Contributor Author
There was a problem hiding this comment.
Should be good now!
Make it possible to refer to Connected, Connection, HttpConnector, etc. without enabling either of the http1/http2 features. This makes feature selection work better for downstream libraries like hyper-openssl, which don't want to commit to any particular protocol. Fix hyperium#2376.
benesch force-pushed the connectors-no-proto branch from 8a002cc to 189a9c0 Compare 
This was referenced Dec 28, 2020
This was referenced Dec 29, 2020
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this pull request Jul 26, 2021
…2377) Make it possible to refer to Connected, Connection, HttpConnector, etc. without enabling either of the http1/http2 features. This makes feature selection work better for downstream libraries like hyper-openssl, which don't want to commit to any particular protocol. Fix hyperium#2376.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make it possible to refer to Connected, Connection, HttpConnector, etc.
without enabling either of the http1/http2 features. This makes feature
selection work better for downstream libraries like hyper-openssl, which
don't want to commit to any particular protocol.
Fix #2376.