Skip to content

feat: isInaccessible API form RTL/DTL #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 23, 2022
Merged

feat: isInaccessible API form RTL/DTL #1128

merged 14 commits into from
Sep 23, 2022

Conversation

@mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Sep 19, 2022 •
edited
Loading

Summary

Implement isInaccessible API from DTL (re-exported from RTL).

This should be a useful building block for features as:

To Do

  • Implement & export basic API
  • Add style-based checks (display: none & opacity: 0) + tests
  • Add iOS accessibilityElementsHidden with tests
  • Add Android importantForAccessibility with tests
  • Add iOS: accessibilityViewIsModal with tests
  • Write docs

Test plan

All checks should pass.
@mdjastrzebski mdjastrzebski changed the title feat: isInaccessible api form RTL/DTL feat: isInaccessible API form RTL/DTL Sep 19, 2022
thymikee
thymikee reviewed Sep 19, 2022
View reviewed changes
thymikee
thymikee reviewed Sep 19, 2022
View reviewed changes
@mdjastrzebski mdjastrzebski marked this pull request as ready for review September 20, 2022 14:04
@mdjastrzebski mdjastrzebski mentioned this pull request Sep 20, 2022
Closed
AugustinLF
AugustinLF requested changes Sep 21, 2022
View reviewed changes
@mdjastrzebski @AugustinLF
Update website/docs/API.md
6c33584 
Co-authored-by: Augustin Le Fèvre <augustin.le-fevre@klarna.com>
@mdjastrzebski mdjastrzebski marked this pull request as draft September 22, 2022 15:54
@mdjastrzebski mdjastrzebski marked this pull request as ready for review September 23, 2022 10:39
thymikee
thymikee reviewed Sep 23, 2022
View reviewed changes
@mdjastrzebski
Copy link
Member Author

mdjastrzebski commented Sep 23, 2022

@AugustinLF I'd like to include this in the upcoming release, could you review it again?
AugustinLF
AugustinLF approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@AugustinLF AugustinLF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢
@mdjastrzebski mdjastrzebski merged commit fa21fc5 into main Sep 23, 2022
@mdjastrzebski mdjastrzebski deleted the feat/is-inaccessible-api branch September 23, 2022 17:33
@mdjastrzebski
Copy link
Member Author

mdjastrzebski commented Sep 26, 2022

🎉 This PR is included in version 11.2.0 🎉
@mdjastrzebski mdjastrzebski mentioned this pull request Sep 27, 2022
Merged
@mdjastrzebski mdjastrzebski mentioned this pull request Oct 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@mdjastrzebski @thymikee @AugustinLF