Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Conversation

@sambhav
Copy link
Member

@sambhav sambhav commented Jan 2, 2023

Thanks for submitting a PR!

This PR moves the build system to poetry and automates the PyPi publishing to git and publish releases based on tags/releases created via the Github UI. It gets rid of the requirement of using bump-version and fetches the package version using importlib-metadata.

It also enables PR builds for read-the-docs.

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@sambhav sambhav force-pushed the poetry branch 3 times, most recently from d47c35f to b458752 Compare January 2, 2023 21:59
@sambhav sambhav merged commit 7007961 into master Jan 2, 2023
@sambhav sambhav deleted the poetry branch January 2, 2023 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants