GitRepository refactoring #2564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
asbjornu approved these changes Jan 28, 2021
| 🎉 This issue has been resolved in version 5.6.5 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In this PR I have moved the code from
GitRepositorytoRepositoryMetadataProviderandGitPreparer, and kept theGitRepositoryas a thin layer on top of the libgit2sharp. It now exposes only the Collections of commits, branches, references, tags, the head. All the other methods were moved toRepositoryMetadataProviderand some toGitPreparer. RenamedRepositoryMetadataProvidertoRepositoryStore(shorter and it's kind of a store, maybe we need a better name for this).I also made the
IGitRepositoryexpose its properties for quering the git for needed information, and the methods that were mutating were moved toIMutatingGitRepositorythat extendsIGitRepository.IMutatingGitRepositoryis used only byGitPreparer, as only this class is mutating the git repository.The dependencies now look like:
IRepositoryStore -> IGitRepository(read only), where theIGitRepositoryis only exposing the collections andIRepositoryStoreis actually the storeIGitPreparer -> IMutatingGitRepository(read/write) - whereIMutatingGitRepositoryexpose methods for clone, checkout, and so on.