[Fix] version detection: Add tests that verify versioning works for sibling and child projects

Fixes jsx-eslint#2218

Author: James Crosetto

CHANGELOG.md

@@ -20,12 +20,14 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 * [`destructuring-assignment`]: fix a false positive for local prop named `context` in SFC ([#2929][] @SyMind)
 * [`jsx-no-target-blank`]: Allow rel="noreferrer" when `allowReferrer` is true ([#2925][] @edemaine)
 * [`boolean-prop-naming`]: add check for typescript "boolean" type ([#2930][] @vedadeepta)
+* version detection: Add tests that verify versioning works for sibling and child projects ([#2943][] @jcrosetto)
 
 ### Changed
 * [Docs] [`jsx-no-constructed-context-values`][]: fix invalid example syntax ([#2910][] @kud)
 * [readme] Replace lists of rules with tables in readme ([#2908][] @motato1)
 * [Docs] added missing curly braces ([#2923][] @Muditxofficial)
 
+[#2943]: https://github.com/yannickcr/eslint-plugin-react/pull/2943
 [#2930]: https://github.com/yannickcr/eslint-plugin-react/pull/2930
 [#2929]: https://github.com/yannickcr/eslint-plugin-react/pull/2929
 [#2925]: https://github.com/yannickcr/eslint-plugin-react/pull/2925

lib/util/version.js

@@ -6,6 +6,7 @@
 'use strict';
 
 const resolve = require('resolve');
+const path = require('path');
 const error = require('./error');
 
 let warnedForMissingVersion = false;
@@ -20,13 +21,14 @@ function resetDetectedVersion() {
  cachedDetectedReactVersion = undefined;
 }
 
-function detectReactVersion() {
+// TODO, semver-major: remove context fallback
+function detectReactVersion(context) {
  if (cachedDetectedReactVersion) {
  return cachedDetectedReactVersion;
  }
 
  try {
- const reactPath = resolve.sync('react', {basedir: process.cwd()});
+ const reactPath = resolve.sync('react', {basedir: context ? path.dirname(context.getFilename()) : process.cwd()});
  const react = require(reactPath); // eslint-disable-line global-require, import/no-dynamic-require
  cachedDetectedReactVersion = react.version;
  return cachedDetectedReactVersion;
@@ -50,7 +52,7 @@ function getReactVersionFromContext(context) {
  if (context.settings && context.settings.react && context.settings.react.version) {
  let settingsVersion = context.settings.react.version;
  if (settingsVersion === 'detect') {
- settingsVersion = detectReactVersion();
+ settingsVersion = detectReactVersion(context);
  }
  if (typeof settingsVersion !== 'string') {
  error('Warning: React version specified in eslint-plugin-react-settings must be a string; '
@@ -66,9 +68,10 @@ function getReactVersionFromContext(context) {
  return confVer.split('.').map((part) => Number(part));
 }
 
-function detectFlowVersion() {
+// TODO, semver-major: remove context fallback
+function detectFlowVersion(context) {
  try {
- const flowPackageJsonPath = resolve.sync('flow-bin/package.json', {basedir: process.cwd()});
+ const flowPackageJsonPath = resolve.sync('flow-bin/package.json', {basedir: context ? path.dirname(context.getFilename()) : process.cwd()});
  const flowPackageJson = require(flowPackageJsonPath); // eslint-disable-line global-require, import/no-dynamic-require
  return flowPackageJson.version;
  } catch (e) {
@@ -87,7 +90,7 @@ function getFlowVersionFromContext(context) {
  if (context.settings.react && context.settings.react.flowVersion) {
  let flowVersion = context.settings.react.flowVersion;
  if (flowVersion === 'detect') {
- flowVersion = detectFlowVersion();
+ flowVersion = detectFlowVersion(context);
  }
  if (typeof flowVersion !== 'string') {
  error('Warning: Flow version specified in eslint-plugin-react-settings must be a string; '