gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 11 Actions 2 Releases 103 Activity

Do not log errors in init-directories container during Gitea launch #708

Merged
pat-s merged 6 commits from :do-not-log-errors-from-init into main 2024-09-11 12:49:18 +00:00
Conversation 6 Commits 6 Files Changed 3 +45 -57
tobiasbp commented 2024-09-02 10:36:44 +00:00
Member
Copy Link

When the init-directories container runs, the shell script init_directory_structure.sh logs to stderr because debugging is enabled with set -x. The output from the script, should be logged to stdout instead. The issue is discussed here: gitea/helm-chart#701

Description of the change

This PR uses the verbose flag with all commands in the script to log what the script is doing.

Benefits

Log entries with incorrect severity ERROR will no longer be logged in Kubernetes.

Possible drawbacks

Log output will change. If someone had a check for certain log entries from the init container, that check would break.

Checklist

Updated unit tests.

When the _init-directories_ container runs, the shell script _init_directory_structure.sh_ logs to _stderr_ because debugging is enabled with _set -x_. The output from the script, should be logged to _stdout_ instead. The issue is discussed here: https://gitea.com/gitea/helm-chart/issues/701 ### Description of the change This PR uses the _verbose_ flag with all commands in the script to log what the script is doing. ### Benefits Log entries with incorrect severity _ERROR_ will no longer be logged in _Kubernetes_. ### Possible drawbacks Log output will change. If someone had a check for certain log entries from the _init container_, that check would break. ### Checklist Updated unit tests.
tobiasbp added 2 commits 2024-09-02 10:36:44 +00:00
Disable debug output to stderr in init_directory_structure.sh 88f46dfdee
Use verbose flag iwith commands in init_directory_structure.sh to improve logging
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 31s
Details
f8c6254fbb
tobiasbp requested review from justusbunsi 2024-09-02 10:36:44 +00:00
tobiasbp requested review from pat-s 2024-09-02 10:36:44 +00:00
tobiasbp changed title from Do not log errors in init-directories container during Gitea launch to WIP: Do not log errors in init-directories container during Gitea launch 2024-09-02 10:39:47 +00:00
tobiasbp added 1 commit 2024-09-02 11:22:18 +00:00
Update unittest to match modified init_directory_structure.sh
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 30s
Details
c4c7255e4a
tobiasbp added 1 commit 2024-09-02 11:46:57 +00:00
Fix: Incorrect unittest for script init_directory_structure.sh
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 30s
Details
a1fc7734e0
tobiasbp added 1 commit 2024-09-02 11:59:32 +00:00
Update unittests for script init_directory_structure.sh in rootless mode
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 30s
Details
49977c31e0
tobiasbp added 1 commit 2024-09-02 12:34:51 +00:00
Fix: Do not expect blank line after 'set -euo pipefail' in tests for script init_directory_structure.sh
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 34s
Details
f310982a1b
tobiasbp changed title from WIP: Do not log errors in init-directories container during Gitea launch to Do not log errors in init-directories container during Gitea launch 2024-09-02 12:54:06 +00:00
techknowlogick approved these changes 2024-09-02 16:07:21 +00:00
pat-s reviewed 2024-09-03 17:35:56 +00:00
pat-s left a comment
Collaborator
Copy Link

I don't think we need all the -v additions.
Let's see what @justusbunsi thinks about this.

We can issue a release afterwards. Thanks for contributing 👍

I don't think we need all the `-v` additions. Let's see what @justusbunsi thinks about this. We can issue a release afterwards. Thanks for contributing 👍
tobiasbp commented 2024-09-04 06:38:16 +00:00
Author
Member
Copy Link

I don't think we need all the -v additions.
Let's see what @justusbunsi thinks about this.

The -v additions are to track the progress of the script as suggested by @techknowlogick in the issue

> I don't think we need all the `-v` additions. > Let's see what @justusbunsi thinks about this. The _-v_ additions are to track the progress of the script [as suggested by @techknowlogick in the issue](https://gitea.com/gitea/helm-chart/issues/701#issuecomment-900341)
tobiasbp commented 2024-09-06 07:18:23 +00:00
Author
Member
Copy Link

It would be nice if this could be a part of the changes for the upcoming chart release that uses Gitea 1.22.2 @justusbunsi

It would be nice if this could be a part of the changes for the upcoming chart release that uses Gitea 1.22.2 @justusbunsi
pat-s commented 2024-09-11 12:48:59 +00:00
Collaborator
Copy Link

OK, merging this now so we can proceed and get this into 1.22.2. Still not fully convinced about all the -v additions but we can also remove them again if needed.

Thanks again @tobiasbp!

OK, merging this now so we can proceed and get this into 1.22.2. Still not fully convinced about all the `-v` additions but we can also remove them again if needed. Thanks again @tobiasbp!
👍 1
pat-s approved these changes 2024-09-11 12:49:09 +00:00
pat-s merged commit 3fdb39df68 into main 2024-09-11 12:49:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
justusbunsi
techknowlogick
pat-s
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#708
No description provided.
Delete Branch ":do-not-log-errors-from-init"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?