gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 11 Actions 2 Releases 103 Activity

Add 'extraContainers' parameter. #697

Merged
justusbunsi merged 12 commits from rossigee/helm-chart:sidecar-containers into main 2024-10-18 13:44:38 +00:00
Conversation 5 Commits 12 Files Changed 4 +32 -1
rossigee commented 2024-08-07 12:47:17 +00:00
Member
Copy Link

Allows the user to run their own sidecar containers.

Description of the change

Adds an 'extraContainers' parameter.

Benefits

Users will be able to run sidecar containers as required by their environment.

Possible drawbacks

N/A

Applicable issues

Checklist

Allows the user to run their own sidecar containers. ### Description of the change Adds an 'extraContainers' parameter. ### Benefits Users will be able to run sidecar containers as required by their environment. ### Possible drawbacks N/A ### Applicable issues * gitea/helm-chart#696 ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm)
rossigee added 1 commit 2024-08-07 12:47:17 +00:00
Add 'extraContainers' parameter.
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
e700f869a2
rossigee requested review from justusbunsi 2024-08-07 12:47:17 +00:00
rossigee requested review from pat-s 2024-08-07 12:47:17 +00:00
rossigee added 1 commit 2024-08-09 01:59:27 +00:00
Move 'extraContainers' below main container.
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
6f44355fcc
pat-s commented 2024-08-09 12:16:40 +00:00
Collaborator
Copy Link

Thanks for contributing!

Could you add some tests following the existing ones (via helm-unittests)?

(I guess we should finally add this to the PR template).

Thanks for contributing! Could you add some tests following the existing ones (via `helm-unittests`)? (I guess we should finally add this to the PR template).
pat-s commented 2024-08-28 08:26:29 +00:00
Collaborator
Copy Link

ping @rossigee

ping @rossigee
rossigee added 1 commit 2024-09-06 02:30:52 +00:00
Merge branch 'main' into sidecar-containers
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
5977ec7169
rossigee added 1 commit 2024-09-06 02:59:13 +00:00
Add a unittest for sidecar containers.
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 31s
Details
0b459fbaed
rossigee commented 2024-09-06 03:01:49 +00:00
Author
Member
Copy Link

@pat-s - I'm not familiar with helm-unittests. I've added a test, but if I try to run it manually...

~/src/gitea/helm-chart$ helm unittest . -f unittests/deployment/sidecar-container.yaml ### Chart [ gitea ] . FAIL sidecar container	unittests/deployment/sidecar-container.yaml	- supports adding a sidecar container	Error: template: gitea/templates/gitea/deployment.yaml:32:28: executing "gitea/templates/gitea/deployment.yaml" at <include (print $.Template.BasePath "/gitea/config.yaml") .>: error calling include: template: no template "gitea/templates/gitea/config.yaml" associated with template "gotpl" Charts: 1 failed, 0 passed, 1 total Test Suites: 1 failed, 0 passed, 1 total Tests: 1 failed, 1 errored, 0 passed, 1 total Snapshot: 0 passed, 0 total Time: 12.268632ms Error: plugin "unittest" exited with error

The existing tests also fail with a similar error message, so I assume it's something I have/haven't done locally.

@pat-s - I'm not familiar with `helm-unittests`. I've added a test, but if I try to run it manually... ``` ~/src/gitea/helm-chart$ helm unittest . -f unittests/deployment/sidecar-container.yaml ### Chart [ gitea ] . FAIL sidecar container unittests/deployment/sidecar-container.yaml - supports adding a sidecar container Error: template: gitea/templates/gitea/deployment.yaml:32:28: executing "gitea/templates/gitea/deployment.yaml" at <include (print $.Template.BasePath "/gitea/config.yaml") .>: error calling include: template: no template "gitea/templates/gitea/config.yaml" associated with template "gotpl" Charts: 1 failed, 0 passed, 1 total Test Suites: 1 failed, 0 passed, 1 total Tests: 1 failed, 1 errored, 0 passed, 1 total Snapshot: 0 passed, 0 total Time: 12.268632ms Error: plugin "unittest" exited with error ``` The existing tests also fail with a similar error message, so I assume it's something I have/haven't done locally.
pat-s commented 2024-09-11 12:59:32 +00:00
Collaborator
Copy Link

@rossigee Try adding - templates/gitea/config.yaml under templates: as shown in the existing deployment unittests.

@rossigee Try adding ` - templates/gitea/config.yaml` under `templates:` as shown in the existing deployment unittests.
👍 1
rossigee added 1 commit 2024-09-20 08:53:58 +00:00
Add missing 'config.yaml'.
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 29s
Details
eab9413ded
rossigee added 5 commits 2024-09-20 09:00:28 +00:00
Fix persistence for postgresql-ha (#704) 2169f9ebb1 
fix #703 Reviewed-on: gitea/helm-chart#704 Reviewed-by: techknowlogick <techknowlogick@noreply.gitea.com> Co-authored-by: pat-s <patrick.schratz@gmail.com> Co-committed-by: pat-s <patrick.schratz@gmail.com>
Add a unittest for sidecar containers. 4aeaa9c5be
Add missing 'config.yaml'. 1560087ce8
Sidecar will be second container in pod. 6f567d354c
Merge branch 'sidecar-containers' of ssh://gitea.com/rossigee/helm-chart into sidecar-containers
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 34s
Details
77e921e94b
rossigee added 1 commit 2024-09-20 09:01:35 +00:00
Merge branch 'main' into sidecar-containers
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 34s
Details
c1ad7dfb2c
justusbunsi added 1 commit 2024-10-18 13:41:53 +00:00
Merge branch 'main' into sidecar-containers
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 38s
Details
87819f7ddf
justusbunsi added the
kind
feature
 label 2024-10-18 13:42:20 +00:00
justusbunsi approved these changes 2024-10-18 13:43:02 +00:00
justusbunsi left a comment
Contributor
Copy Link

LGTM. Thanks for your contribution. Sorry for the delayed response.

LGTM. Thanks for your contribution. Sorry for the delayed response.
justusbunsi merged commit aa9808bc27 into main 2024-10-18 13:44:38 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
justusbunsi
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
kind
feature
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#697
No description provided.
Delete Branch "rossigee/helm-chart:sidecar-containers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?