gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 13 Actions Releases 103 Activity

DRY improvements #664

Merged
pat-s merged 36 commits from Ceddaerrix/gitea-helm-chart:DRY-improvements into main 2024-06-06 20:39:42 +00:00
Conversation 1 Commits 36 Files Changed 4 +45 -2
Ceddaerrix commented 2024-06-05 15:53:53 +00:00
Contributor
Copy Link

Description of the change

Adding support for DRY principle (via use of the TPL function) to the PVC storage class and the ingress class

Benefits

It allows to reference a variable into another one to avoid duplicating them (or using YAML anchors).
It is useful and valuable when including Gitea into an umbrella chart with multiple components and to have a single variable while the components variable only refer to that single one.

Example 1

global: persistence: storageClass: "storage-class" persistence: storageClass: "{{ .Values.global.persistence.storageClass }}"

This results in having spec.storageClassName equal to storage-class in the PVC object

Example 2

global: ingress: className: "ingress-class" ingress: className: "{{ .Values.global.ingress.className}}"

This results in having spec.ingressClassName equal to ingress-class in the Ingress object

Possible drawbacks

N/A

Checklist

  • Templating unittests are added
### Description of the change Adding support for DRY principle (via use of the TPL function) to the PVC storage class and the ingress class ### Benefits It allows to reference a variable into another one to avoid duplicating them (or using YAML anchors). It is useful and valuable when including Gitea into an umbrella chart with multiple components and to have a single variable while the components variable only refer to that single one. Example 1 ``` global: persistence: storageClass: "storage-class" persistence: storageClass: "{{ .Values.global.persistence.storageClass }}" ``` This results in having `spec.storageClassName` equal to `storage-class` in the PVC object Example 2 ``` global: ingress: className: "ingress-class" ingress: className: "{{ .Values.global.ingress.className}}" ``` This results in having `spec.ingressClassName` equal to `ingress-class` in the Ingress object ### Possible drawbacks N/A ### Checklist - [X] Templating unittests are added
Ceddaerrix added 31 commits 2024-06-05 15:53:54 +00:00
Improving DRY principle support on gitea Ingress host name 793ef64472
Improving DRY principle support on gitea Ingress host name accf620a30
Creating file for unit test of ingress configuration
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 28s
Details
87dd3f8066
Editing asserts indentation
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 32s
Details
b143e50567
Correcting lint errors in ingress-configuration.yaml
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 32s
Details
1de07a6c48
Improving DRY support on gitea host name d96bce3aee 
Adding TPL function to 'gitea.inline_configuration.defaults.server' since (index .Values.ingress.hosts 0).host for server "DOMAIN" key
Add unittests/deployment/inline-config.yaml 2ef96c449b
Improving DRY support - adding unit test for templates/gitea/config.yaml first document
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 1h8m28s
Details
3645ddd276
Merge branch 'main' into main
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 16s
Details
3297d86e94
Merge branch 'main' into main
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 23s
Details
c50e719ad3
Reverting last change in '_helpers.tpl' "gitea.inline_configuration.defaults.server"
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 22s
Details
0682c36c10
Reintroducing change in '_helpers.tpl' "gitea.inline_configuration.defaults.server" (line 322)
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 21s
Details
a85a6dc3e6
Merge branch 'main' into main
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 23s
Details
bc8dda59bc
Merge branch 'main' into main
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 21s
Details
479e0c4f29
Enforcing unix line ending f6cde62585
Converting assets to matchRegex 57e8697d52
Merge branch 'main' of https://gitea.com/Ceddaerrix/gitea-helm-chart
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 0s
Details
69d58ba606
Merge branch 'main' into main
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 0s
Details
2812387665
Correcting asserts matchRegex patterns 83ba8c260a
Merge branch 'main' of https://gitea.com/Ceddaerrix/gitea-helm-chart
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 24s
Details
a504545402
Correcting pattern of first matchRegex
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 53s
Details
3fb40da20c
Correcting first assert
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 29s
Details
560e6aa5f6
Adding EOL to unittests/deployment/inline-config.yaml
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 25s
Details
ba74af0f01
Update unittests/deployment/inline-config.yaml
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 25s
Details
6b8f45b711
Fixing lint issues in unittests/deployment/inline-config.yaml
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 26s
Details
fd0888331e
Merge branch 'main' into main
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 31s
Details
7e1687ad73
Adding use of TPL to PVC storageClass & ingressClass ffb15f0583
Merge branch 'main' of https://gitea.com/Ceddaerrix/gitea-helm-chart b552acaf1c
Adding use of TPL to PVC storageClass & ingressClass 29f9cf0b93
Merge branch 'DRY-improvements' of https://gitea.com/Ceddaerrix/gitea-helm-chart into DRY-improvements 52001b1265
Correcting unit test isKind syntax
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 33s
Details
30c8feacd8
Ceddaerrix requested review from justusbunsi 2024-06-05 15:53:54 +00:00
Ceddaerrix requested review from pat-s 2024-06-05 15:53:54 +00:00
Ceddaerrix added 1 commit 2024-06-05 16:04:46 +00:00
Rebase/merge
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 19s
Details
f9011fb23e
Ceddaerrix added 1 commit 2024-06-05 16:35:11 +00:00
Correcting loginh into 'gitea.persistence.storageClass'
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 24s
Details
e96e5345b2
Ceddaerrix added 1 commit 2024-06-05 16:37:26 +00:00
Correcting unit test isKind syntax
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 33s
Details
9f21bc008f
Ceddaerrix added 1 commit 2024-06-05 17:11:57 +00:00
Update unittests/deployment/ingress-configuration.yaml
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 34s
Details
bc3915ae4d
Ceddaerrix added 1 commit 2024-06-05 18:23:21 +00:00
Correcting ingress unit test name
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 35s
Details
3aa520a0d7
pat-s approved these changes 2024-06-06 20:39:32 +00:00
pat-s left a comment
Collaborator
Copy Link

Thanks!

LGTM, thanks also for adding unit tests!

Given the working tests, I am confident enough we can include this directly into the next release.

Thanks! LGTM, thanks also for adding unit tests! Given the working tests, I am confident enough we can include this directly into the next release.
pat-s merged commit b7b60dd51f into main 2024-06-06 20:39:42 +00:00
pat-s referenced this issue from a commit 2024-06-06 20:39:44 +00:00
DRY improvements (#664)
Ceddaerrix deleted branch DRY-improvements 2024-11-20 14:59:38 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
justusbunsi
pat-s
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#664
No description provided.
Delete Branch "Ceddaerrix/gitea-helm-chart:DRY-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?