gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 11 Actions Releases 103 Activity

Prevent custom HOST name from being overwritten in mysql, postgresql, cache #23

Merged
techknowlogick merged 5 commits from mmuenster/helm-chart-mm:master into master 2020-09-18 03:21:31 +00:00
Conversation 2 Commits 5 Files Changed 1 +6
mmuenster commented 2020-09-17 16:12:48 +00:00
Contributor
Copy Link

This change would allow a user not in a default cluster to use Gitea. The default dns values are set here for postgresql and here for mysql and memcache. Before, these default values overwrote any value set in gitea.config.database/cache.HOST. This PR would use these default values whenever gitea.config.database/cache.HOST is not set, and use the value in gitea.config.database/cache.HOST when it is set.

Similar code can be found here, where the server domain is conditionally set to gitea.default_domain.

This change would allow a user not in a default cluster to use Gitea. The default dns values are set [here](https://gitea.com/gitea/helm-chart/src/branch/master/templates/_helpers.tpl#L55) for postgresql and [here](https://gitea.com/gitea/helm-chart/src/branch/master/templates/_helpers.tpl#L78-L84) for mysql and memcache. Before, these default values overwrote any value set in gitea.config.database/cache.HOST. This PR would use these default values whenever gitea.config.database/cache.HOST is not set, and use the value in gitea.config.database/cache.HOST when it is set. Similar code can be found [here](https://gitea.com/gitea/helm-chart/src/branch/master/templates/gitea/config.yaml#L41), where the server domain is conditionally set to [gitea.default_domain](https://gitea.com/gitea/helm-chart/src/branch/master/templates/_helpers.tpl#L86-L88).
mmuenster added 5 commits 2020-09-17 16:12:50 +00:00
Added useDefaultHost to built in database values. 129936b770
Updated db host logic d08d5fdd4e 
Config map uses "postgresql/mysql.dns" when useDefaultHost is true, and the value from gitea.config.database.HOST when useDefaultHost is false.
Eliminated need for useDefaultHost value 16fcb6f7ab 
Using whether gitea.config.database.HOST exists instead in the values file. If true, don't overwrite. If false, use "mysql/postgresql.dns"
Deleted useDefaultHost value fc4f1ee1cc 
no longer needed
Adding same changes to cache
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6b083a6456
lunny added the
kind
enhancement
 label 2020-09-18 02:39:00 +00:00
lunny approved these changes 2020-09-18 02:39:17 +00:00
Dismissed
techknowlogick approved these changes 2020-09-18 03:21:21 +00:00
Dismissed
techknowlogick merged commit c168d47181 into master 2020-09-18 03:21:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
kind
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#23
No description provided.
Delete Branch "mmuenster/helm-chart-mm:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?