allow for additional container environment variables #16

Jasper-Ben · 2020-08-31T14:20:45Z

Jasper-Ben commented

2020-08-31 14:20:45 +00:00

e.g. useful for setting the timezone "TZ=Europe/Berlin"

luhahn requested changes 2020-09-01 07:05:24 +00:00

Dismissed

templates/gitea/statefulset.yaml Outdated

              @@ -70,6 +70,7 @@ spec:  
      ) \  
      {{- end }}  
      '  
      {{- toYaml .Values.env | trim | nindent 12 }}  
  

luhahn commented

2020-09-01 06:39:58 +00:00

Why is this at the end of the init container?

Jasper-Ben commented

2020-09-01 08:35:40 +00:00

Whoops, my bad. Got distracted ?

templates/gitea/statefulset.yaml Outdated

              @@ -87,6 +88,7 @@ spec:  
      value: {{ .Values.gitea.config.server.SSH_LISTEN_PORT | quote }}  
      - name: SSH_PORT  
      value: {{ .Values.gitea.config.server.SSH_PORT | quote }}  
      {{- toYaml .Values.env | trim | nindent 12 }}  
  

luhahn commented

2020-09-01 07:01:58 +00:00

Why using trim?

We could think about using something like that:

{{- range .Values.env }} - name: {{ .name | quote }} value: {{ .value | quote }} {{- end }}

To ensure that only strings are created, since kubernetes will fail on ints and other types

Why using trim? We could think about using something like that: ``` {{- range .Values.env }} - name: {{ .name | quote }} value: {{ .value | quote }} {{- end }} ``` To ensure that only strings are created, since kubernetes will fail on ints and other types

Jasper-Ben commented

2020-09-01 08:53:15 +00:00

Why using trim?

I am not sure, how Kubernetes would handle name: "foo " during variable assignment. The quote part is definitely a good idea though.

> Why using trim? I am not sure, how Kubernetes would handle `name: "foo "` during variable assignment. The `quote` part is definitely a good idea though.

luhahn commented

2020-09-01 08:57:23 +00:00

Good point, maybe we should use this ?

{{ .name | quote | trim }}

Good point, maybe we should use this ? ``` {{ .name | quote | trim }} ```

Jasper-Ben commented

2020-09-01 09:04:56 +00:00

Done ?

values.yaml Outdated

              @@ -52,6 +52,10 @@ tolerations: []  
        
     affinity: {}  
        
     env: []

luhahn commented

2020-08-31 15:14:18 +00:00

You're adding this to statefulset, so it should be there in the values.

 statefulset:  env: []

You're adding this to statefulset, so it should be there in the values. ```yaml statefulset: env: [] ```

Jasper-Ben marked this conversation as resolved

luhahn requested changes 2020-09-01 09:19:40 +00:00

Dismissed

templates/gitea/statefulset.yaml Outdated

              @@ -89,1 +89,4 @@  
      value: {{ .Values.gitea.config.server.SSH_PORT | quote }}  
      {{- range .Values.statefulset.env }}  
      - name: {{ .name | quote | trim }}  
      value: {{ .value | quote }}  
  

luhahn commented

2020-09-01 09:19:32 +00:00

Sorry, just did some testing. Trim does not really work with quote.
And you're right, kubernetes does not accept whitespaces at the end. However it does not throw an error but completely refuses to fire up the pod without any message.

This solves this issue:

{{- range .Values.statefulset.env }} - name: {{ .name | quote | nospace }} value: {{ .value | quote | nospace }} {{- end }}

Sorry, just did some testing. Trim does not really work with quote. And you're right, kubernetes does not accept whitespaces at the end. However it does not throw an error but completely refuses to fire up the pod without any message. This solves this issue: ``` {{- range .Values.statefulset.env }} - name: {{ .name | quote | nospace }} value: {{ .value | quote | nospace }} {{- end }} ```

luhahn commented

2020-09-01 09:20:22 +00:00

And you're right again, we only need to trim the name. The value can have spaces :)

Jasper-Ben commented

2020-09-08 13:15:59 +00:00

so value should be value: {{ .value | quote }} right?

so value should be `value: {{ .value | quote }}` right?

luhahn commented

2020-09-09 08:40:49 +00:00

yes :)