Let service.ssh.externalIPs and service.ssh.externalTrafficPolicy be configurable #15

onedr0p · 2020-08-30T19:17:59Z

onedr0p commented

2020-08-30 19:17:59 +00:00

Add two new config options:

|service.ssh.externalTrafficPolicy| If `service.ssh.type` is `NodePort` or `LoadBalancer`, set this to `Local` to enable source IP preservation | Cluster | |service.ssh.externalIPs| SSH service external IP addresses |[]|

Having these be configurable would be great. Let me know if you need any further changes.

Add two new config options: ``` |service.ssh.externalTrafficPolicy| If `service.ssh.type` is `NodePort` or `LoadBalancer`, set this to `Local` to enable source IP preservation | Cluster | |service.ssh.externalIPs| SSH service external IP addresses |[]| ``` Having these be configurable would be great. Let me know if you need any further changes.

onedr0p added 4 commits 2020-08-30 19:18:02 +00:00

externalIPs and externalTrafficPolicy 76f08700ab

let service.ssh.externalIPs and service.ssh.externalTrafficPolicy be configurable

bump chart version 20a27e6e8f

document service.ssh.externalTrafficPolicy and service.ssh.externalIPs 7b488a4617

externalTrafficPolicy and externalIPs example in values

continuous-integration/drone/pr Build is passing

Details

ee069753f1

luhahn commented

2020-08-31 07:09:50 +00:00

Thank you for the PR, I will check this today on my test cluster.

lunny added the

kind

enhancement

label 2020-08-31 08:12:35 +00:00

luhahn requested changes 2020-09-01 08:50:05 +00:00

Dismissed

luhahn left a comment

Just a little something I'd like to change. Otherwise I've tested this PR on my Cluster and it looks fine to me :)

README.md Outdated

              @@ -201,6 +201,8 @@ Like the admin user the ldap settings can be updated but also disabled or delete  
     |service.http.port| Port for web traffic | 3000 |  
     |service.ssh.type| Kubernetes service type for ssh traffic | ClusterIP |  
     |service.ssh.port| Port for ssh traffic | 22 |  
     |service.ssh.externalTrafficPolicy| If `service.ssh.type` is `NodePort` or `LoadBalancer`, set this to `Local` to enable source IP preservation | Cluster |  
  