Add support for metrics and pprof #100

JosefWN · 2021-01-10T21:19:14Z

JosefWN commented

2021-01-10 21:19:14 +00:00

Adds support for toggling support for pprof and metrics:

gitea:  pprofEnabled: true   metrics:  enabled: true  serviceMonitor:  enabled: true

Adds support for toggling support for `pprof` and metrics: ```yaml gitea: pprofEnabled: true metrics: enabled: true serviceMonitor: enabled: true ```

JosefWN force-pushed metrics-and-profiling from 61bea0a3e4 to 416bb095eb

2021-01-10 21:20:47 +00:00

Compare

techknowlogick requested changes 2021-01-10 22:13:47 +00:00

Dismissed

techknowlogick left a comment

please remove the .ds_store file that was added

JosefWN commented

2021-01-10 22:32:44 +00:00

please remove the .ds_store file that was added

Dang, that's what I get for using git add -A... Removed: 2dfac46d45

> please remove the .ds_store file that was added Dang, that's what I get for using `git add -A`... Removed: https://gitea.com/gitea/helm-chart/commit/2dfac46d450512982a2662a40916fae960bd07db

JosefWN requested review from techknowlogick 2021-01-10 22:33:34 +00:00

luhahn requested changes 2021-01-11 08:12:19 +00:00

Dismissed

templates/gitea/config.yaml Outdated

              @@ -65,6 +69,14 @@ stringData:  
      {{- if not (hasKey .Values.gitea.config.server "APP_DATA_PATH") -}}  
      {{- $_ := set .Values.gitea.config.server "APP_DATA_PATH" "/data" -}}  
      {{- end -}}  
      {{- if not (hasKey .Values.gitea.config.server "PPROF_ENABLED") -}}  
  

luhahn commented

2021-01-11 08:12:03 +00:00

Question, why don't you use .values.gitea.config.server.PPROF_ENABLED directly instead of .values.gitea.pprofEnabled ?

If you want to set a default you can do this in this file:

{{- if not (hasKey .Values.gitea.config.server "PPROF_ENABLED") -}} {{- $_ := set .Values.gitea.config.server "PPROF_ENABLED" false -}} {{- end -}}

Question, why don't you use .values.gitea.config.server.PPROF_ENABLED directly instead of .values.gitea.pprofEnabled ? If you want to set a default you can do this in this file: ```yaml {{- if not (hasKey .Values.gitea.config.server "PPROF_ENABLED") -}} {{- $_ := set .Values.gitea.config.server "PPROF_ENABLED" false -}} {{- end -}} ```

JosefWN commented

2021-01-11 13:10:27 +00:00

Sure, changed in: ac8a4d87ba

Sure, changed in: https://gitea.com/gitea/helm-chart/commit/ac8a4d87bac62d0820c77190c7b65f3c7a737eb2

lafriks marked this conversation as resolved

JosefWN requested review from luhahn 2021-01-11 13:10:34 +00:00

luhahn approved these changes 2021-01-11 16:00:22 +00:00

Dismissed

luhahn left a comment

looks good to me :)

JosefWN force-pushed metrics-and-profiling from ac8a4d87ba to 5be7d84bd2

2021-01-14 15:52:57 +00:00

Compare

JosefWN commented

2021-01-14 15:54:07 +00:00

@techknowlogick I just rebased on master, do you have time to take another look for a second approval? :)

JosefWN force-pushed metrics-and-profiling from 5be7d84bd2 to c46d5180d5

2021-01-21 07:56:36 +00:00

Compare

JosefWN commented

2021-01-21 07:58:50 +00:00

@luhahn I rebased again now, can you please help me find someone to give a second approval before my fork is deleted in a week?

Hi,\n\nWe are sorry we have no enough diskspace to store all the mirror repositories. We will remove all of them, please back up all your mirror repositories on https://gitea.com. We will do that about 1 week later

@luhahn I rebased again now, can you please help me find someone to give a second approval before my fork is deleted in a week? > Hi,\n\nWe are sorry we have no enough diskspace to store all the mirror repositories. We will remove all of them, please back up all your mirror repositories on https://gitea.com. We will do that about 1 week later

luhahn commented

2021-01-21 13:11:36 +00:00

Sure. Will try later that day when techknowlogick is available