gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 13 Actions Releases 103 Activity

Fix runner label issues (#739)
All checks were successful
check-and-test / check-and-test (push) Successful in 39s
Details

Browse Source 
### Description of the change This addresses 2 bugs regarding configured runner labels: - `Cannot find: node in PATH` due to a default label that matches the runner host, not the docker-in-docker environment - After changing the runner config, users have to manually replace the StatefulSet Pod of the runner ### Benefits - Out-of-the-box functioning node environment - Auto-updated runner config on changes in values ### Applicable issues - fixes gitea/helm-chart#728 - fixes gitea/helm-chart#725 ### Additional information With removing the default labels from `values.yaml`, the act runner defaults will be used for new runners which fixes the "missing node" issue. I had issues replacing the labels once the Chart defaults were used, so users might have to replace their runner manually if this is an issue. ### Checklist - [x] Templating unittests are added Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com> Reviewed-on: gitea/helm-chart#739 Co-authored-by: justusbunsi <sk.bunsenbrenner@gmail.com> Co-committed-by: justusbunsi <sk.bunsenbrenner@gmail.com>
This commit was merged in pull request #739.
This commit is contained in:
justusbunsi
2024-12-17 13:30:31 +00:00
committed by justusbunsi
parent f4d1a6b516
commit e733287dc2
3 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
unittests/act_runner/statefulset.yaml
View File

@@ -4,6 +4,7 @@ release:
namespace: testing
templates:
- templates/gitea/act_runner/statefulset.yaml
- templates/gitea/act_runner/config-act-runner.yaml
tests:
- it: doesn't renders a StatefulSet by default
template: templates/gitea/act_runner/statefulset.yaml
@@ -54,6 +55,24 @@ tests:
secretKeyRef:
name: "gitea-unittests-actions-token"
key: "token"
- it: renders a StatefulSet (that tracks changes of the runner configuration as annotation)
template: templates/gitea/act_runner/statefulset.yaml
set:
image.tag: "1.22.3" # lock image tag to prevent test failures on future Gitea upgrades
actions:
enabled: true
existingSecret: "my-secret"
existingSecretKey: "my-secret-key"
asserts:
- hasDocuments:
count: 1
- containsDocument:
kind: StatefulSet
apiVersion: apps/v1
name: gitea-unittests-act-runner
- equal:
path: spec.template.metadata.annotations["checksum/config"]
value: "2a2200e80fc29111d18b675789c265cd3d5f917754850f946f1ce3c55dcd65f8"
- it: renders a StatefulSet (with correct GITEA_INSTANCE_URL env with default act-runner specific LOCAL_ROOT_URL)
template: templates/gitea/act_runner/statefulset.yaml
set: