Fix admin + ldap configuration (#183) All checks were successful continuous-integration/drone/push Build is passing
All checks were successful
continuous-integration/drone/push Build is passing
This fixes several flaws introduced by commits for #169 (see c49dc047a4). - Respect kebab-case ldap bind inline definition - Prevent camelCase ldap bind inline definition from being overridden by empty string - Create admin account when `existingSecret` is used Reviewed-on: gitea/helm-chart#183 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: luhahn <luhahn@noreply.gitea.io> Co-authored-by: justusbunsi <justusbunsi@noreply.gitea.io> Co-committed-by: justusbunsi <justusbunsi@noreply.gitea.io> This commit was merged in pull request #183.
This commit is contained in:
@@ -108,11 +108,11 @@ app.kubernetes.io/instance: {{ .Release.Name }} | ||||
{{- end -}} | ||||
| ||||
{{- define "gitea.ldap_settings" -}} | ||||
{{- if or (not (hasKey .Values.gitea.ldap "bindDn")) (not (hasKey .Values.gitea.ldap "bind-dn")) -}} | ||||
{{- if and (not (hasKey .Values.gitea.ldap "bindDn")) (not (hasKey .Values.gitea.ldap "bind-dn")) -}} | ||||
{{- $_ := set .Values.gitea.ldap "bindDn" "" -}} | ||||
{{- end -}} | ||||
| ||||
{{- if or (not (hasKey .Values.gitea.ldap "bindPassword")) (not (hasKey .Values.gitea.ldap "bind-password")) -}} | ||||
{{- if and (not (hasKey .Values.gitea.ldap "bindPassword")) (not (hasKey .Values.gitea.ldap "bind-password")) -}} | ||||
{{- $_ := set .Values.gitea.ldap "bindPassword" "" -}} | ||||
{{- end -}} | ||||
| ||||
| ||||
@@ -40,7 +40,7 @@ stringData: | ||||
{{- end }} | ||||
set -x; \ | ||||
gitea migrate; \ | ||||
{{- if and .Values.gitea.admin.username .Values.gitea.admin.password }} | ||||
{{- if or .Values.gitea.admin.existingSecret (and .Values.gitea.admin.username .Values.gitea.admin.password) }} | ||||
gitea admin create-user --username "${GITEA_ADMIN_USERNAME}" --password "${GITEA_ADMIN_PASSWORD}" --email {{ .Values.gitea.admin.email }} --admin --must-change-password=false \ | ||||
|| \ | ||||
gitea admin change-password --username "${GITEA_ADMIN_USERNAME}" --password "${GITEA_ADMIN_PASSWORD}" \ | ||||
| ||||
@@ -63,9 +63,9 @@ spec: | ||||
name: {{ .Values.gitea.ldap.existingSecret }} | ||||
{{- else }} | ||||
- name: GITEA_LDAP_BIND_DN | ||||
value: {{ .Values.gitea.ldap.bindDn | quote }} | ||||
value: {{ default (index .Values.gitea.ldap "bind-dn") .Values.gitea.ldap.bindDn | quote }} | ||||
- name: GITEA_LDAP_PASSWORD | ||||
value: {{ .Values.gitea.ldap.bindPassword | quote }} | ||||
value: {{ default (index .Values.gitea.ldap "bind-password") .Values.gitea.ldap.bindPassword | quote }} | ||||
{{- end }} | ||||
{{- if .Values.gitea.admin.existingSecret }} | ||||
- name: GITEA_ADMIN_USERNAME | ||||
| ||||
Reference in New Issue
Block a user