gitea/helm-gitea
Fork 168
Code Issues 55 Pull Requests 10 Actions Releases 103 Activity

fix: quote node selector values (#796)
All checks were successful
check-and-test / check-and-test (push) Successful in 47s
Details

Browse Source 
### Description of the change This pr add quotes to values for _nodeSelector_ entries. This is needed if the value is a _boolean_. An example is using [Spot VMs](https://cloud.google.com/kubernetes-engine/docs/concepts/spot-vms) on _GCP_: ```` apiVersion: v1 kind: Pod spec: nodeSelector: cloud.google.com/gke-spot: "true" ```` Currently, the Chart uses the _toYaml_ function when adding the _nodeSelector_ values, however, _toYaml_ does not quote the values as discussed [here](https://github.com/helm/helm/issues/4262). The same issue, for ingress configurations, was discussed in [this issue](https://gitea.com/gitea/helm-chart/issues/483), and fixed in [this PR](https://gitea.com/gitea/helm-chart/pulls/497). ### Benefits Allows the usage of _boolean_ values for _nodeSelectors_. ### Possible drawbacks None known. Co-authored-by: tobias.petersen <tobias.petersen@unity3d.com> Co-authored-by: pat-s <pat-s@noreply.gitea.com> Reviewed-on: https://gitea.com/gitea/helm-chart/pulls/796 Reviewed-by: pat-s <pat-s@noreply.gitea.com> Co-authored-by: tobiasbp <tobiasbp@noreply.gitea.com> Co-committed-by: tobiasbp <tobiasbp@noreply.gitea.com>
This commit was merged in pull request #796.
This commit is contained in:
Tobias Balle-Petersen
2025-02-19 13:20:18 +00:00
committed by pat-s
parent edd8557bb0
commit a983974568
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
templates/gitea/act_runner/job.yaml
View File

@@ -86,9 +86,9 @@ spec:
{{- if .Values.persistence.subPath }}
subPath: {{ .Values.persistence.subPath }}
{{- end }}
{{- with .Values.actions.provisioning.nodeSelector }}
{{- range $key, $value := .Values.actions.provisioning.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- with .Values.actions.provisioning.affinity }}
affinity:

4
templates/gitea/act_runner/statefulset.yaml
View File

@@ -96,9 +96,9 @@ spec:
{{- with .Values.actions.statefulset.dind.extraVolumeMounts }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.actions.statefulset.nodeSelector }}
{{- range $key, $value := .Values.actions.statefulset.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- with .Values.actions.statefulset.affinity }}
affinity:

4
templates/gitea/deployment.yaml
View File

@@ -360,9 +360,9 @@ spec:
hostAliases:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.nodeSelector }}
{{- range $key, $value := .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- with .Values.affinity }}
affinity: