gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 13 Actions 1 Releases 103 Activity

Fix namespace templating inconsistencies (#713)
All checks were successful
check-and-test / check-and-test (push) Successful in 35s
Details

Browse Source 
### Description of the change Added namespaces to all the template files to better support alternate templaters in gitops systems ### Benefits Gitops system that have different ways of handling helm templates can actually deploy this chart correct, especially through subcharts ### Possible drawbacks Potential regression when upgrading, though this should be unlikely per @jessesanford 's comments with it defaulting back to the existing behaviour ### Applicable issues - Addresses gitea/helm-chart#630 - Addresses gitea/helm-chart#557 - Addresses gitea/helm-chart#623 ### Checklist - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md` Co-authored-by: SorsOps <80043879+sorsOps@users.noreply.github.com> Reviewed-on: gitea/helm-chart#713 Reviewed-by: pat-s <pat-s@noreply.gitea.com> Reviewed-by: justusbunsi <justusbunsi@noreply.gitea.com> Co-authored-by: SorsOps <sorsops@noreply.gitea.com> Co-committed-by: SorsOps <sorsops@noreply.gitea.com>
This commit was merged in pull request #713.
This commit is contained in:
SorsOps
2024-10-08 16:40:23 +00:00
committed by justusbunsi
parent c039673e5a
commit a08e39f8ff
14 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
templates/tests/test-http-connection.yaml
View File

@@ -3,6 +3,7 @@ apiVersion: v1
kind: Pod
metadata:
name: "{{ include "gitea.fullname" . }}-test-connection"
namespace: {{ .Values.namespace | default .Release.Namespace }}
labels:
{{ include "gitea.labels" . | nindent 4 }}
annotations: