Properly mark pg_stat_get_subscription() as returning a set.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 8 Mar 2021 23:47:23 +0000 (18:47 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 8 Mar 2021 23:47:23 +0000 (18:47 -0500)
commitfed10d4eec79242688382d03ddca82007160ee6f
tree80a52f70177423993e3b52655725c7c6c647ba9f
parent5c06abb9b97b69513a3998cccf89556e73052e02
Properly mark pg_stat_get_subscription() as returning a set.

The initial catalog data for this function failed to set proretset
or provide a prorows estimate.  It accidentally worked anyway when
invoked in the FROM clause, because the executor isn't too picky
about this; but the planner didn't expect the function to return
multiple rows, which could lead to bad plans.  Also the function
would fail if invoked in the SELECT list.

We can't easily back-patch this fix, but fortunately the bug's
consequences aren't awful in most cases.  Getting this right is
mainly an exercise in future-proofing.

Discussion: https://postgr.es/m/1636062.1615141782@sss.pgh.pa.us
src/include/catalog/catversion.h
src/include/catalog/pg_proc.dat