Improve common/logging.c's support for multiple verbosity levels.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 17 Sep 2020 16:52:18 +0000 (12:52 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 17 Sep 2020 16:52:18 +0000 (12:52 -0400)
commit99175141c9254318e5894ac30b9fdb622612acda
tree2afcbc8352aca1296a371c41cc7d3a2a2ccecb3a
parentb7f2dd959a5082540adbeee1dea0c0b1c154374f
Improve common/logging.c's support for multiple verbosity levels.

Instead of hard-wiring specific verbosity levels into the option
processing of client applications, invent pg_logging_increase_verbosity()
and encourage clients to implement --verbose by calling that.  Then,
the common convention that more -v's gets you more verbosity just works.

In particular, this allows resurrection of the debug-grade messages that
have long existed in pg_dump and its siblings.  They were unreachable
before this commit due to lack of a way to select PG_LOG_DEBUG logging
level.  (It appears that they may have been unreachable for some time
before common/logging.c was introduced, too, so I'm not specifically
blaming cc8d41511 for the oversight.  One reason for thinking that is
that it's now apparent that _allocAH()'s message needs a null-pointer
guard.  Testing might have failed to reveal that before 96bf88d52.)

Discussion: https://postgr.es/m/1173106.1600116625@sss.pgh.pa.us
12 files changed:
doc/src/sgml/ref/pg_dump.sgml
doc/src/sgml/ref/pg_dumpall.sgml
doc/src/sgml/ref/pg_restore.sgml
src/bin/pg_archivecleanup/pg_archivecleanup.c
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dumpall.c
src/bin/pg_dump/pg_restore.c
src/bin/pg_rewind/pg_rewind.c
src/bin/pgbench/pgbench.c
src/common/logging.c
src/include/common/logging.h