Fix locking bugs that could corrupt pg_control.
authorThomas Munro <tmunro@postgresql.org>
Mon, 8 Jun 2020 01:57:24 +0000 (13:57 +1200)
committerThomas Munro <tmunro@postgresql.org>
Mon, 8 Jun 2020 01:57:24 +0000 (13:57 +1200)
commit57cb8063089a7d6c54e27adfd5d028cc01f21536
tree6f94c16e82d493347025b3f7fc7f474510703369
parentd094bf93014b467cc3c129cc0d7d3f0f69968c96
Fix locking bugs that could corrupt pg_control.

The redo routines for XLOG_CHECKPOINT_{ONLINE,SHUTDOWN} must acquire
ControlFileLock before modifying ControlFile->checkPointCopy, or the
checkpointer could write out a control file with a bad checksum.

Likewise, XLogReportParameters() must acquire ControlFileLock before
modifying ControlFile and calling UpdateControlFile().

Back-patch to all supported releases.

Author: Nathan Bossart <bossartn@amazon.com>
Author: Fujii Masao <masao.fujii@oss.nttdata.com>
Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/70BF24D6-DC51-443F-B55A-95735803842A%40amazon.com
src/backend/access/transam/xlog.c