Prevent underflow in KeepLogSeg().
authorNathan Bossart <nathan@postgresql.org>
Thu, 27 Apr 2023 20:43:48 +0000 (13:43 -0700)
committerNathan Bossart <nathan@postgresql.org>
Thu, 27 Apr 2023 21:32:40 +0000 (14:32 -0700)
commit137003036972be4895ccdf802c640d037a5e607e
treefa98060bd545ffd485dcc7fdc6b3a63b95e0c470
parentc74f88c406dced7e23527d036b41e1a3213d27ea
Prevent underflow in KeepLogSeg().

The call to XLogGetReplicationSlotMinimumLSN() might return a
greater LSN than the one given to the function.  Subsequent segment
number calculations might then underflow, which could result in
unexpected behavior when removing or recyling WAL files.  This was
introduced with max_slot_wal_keep_size in c655077639.  To fix, skip
the block of code for replication slots if the LSN is greater.

Reported-by: Xu Xingwang
Author: Kyotaro Horiguchi
Reviewed-by: Junwang Zhao
Discussion: https://postgr.es/m/17903-4288d439dee856c6%40postgresql.org
Backpatch-through: 13
src/backend/access/transam/xlog.c