From f475fdd5536c3230ceb72c29e4e998d9b1989a65 Mon Sep 17 00:00:00 2001 From: Pierre Equoy Date: Tue, 25 Jun 2019 15:26:13 +0800 Subject: bin:pm_test: use the proper fwts.log file to compute sleep/resume times pm_test relies on fwts_test.py from checkbox_support. However, fwts_test.py --log argument takes a filename without and appends `.log` to it. When calling it from pm_test with argument `--log={}/fwts.log`, we are in fact working on file `fwts.log.log` instead of `fwts.log`, so the log file used for later computation is erroneous (it doesn't contain the "Iteration n" markers needed to find the average sleep/resume times), which leads to wrong results and ultimately a set of jobs (power-management/suspend-*-cycles-time-check*) that always fail. LP: #1834127 --- bin/pm_test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'bin') diff --git a/bin/pm_test b/bin/pm_test index dd9e1a0..f455858 100755 --- a/bin/pm_test +++ b/bin/pm_test @@ -188,7 +188,7 @@ class PowerManagementOperation(): command_tpl = '-s s3 --s3-device-check ' \ '--s3-sleep-delay=30 --s3-multiple={}' if self.args.log_dir: - command_tpl = '--log={}/fwts.log '.format( + command_tpl = '--log={}/fwts '.format( self.args.log_dir) + command_tpl command_tpl = '{} ' + command_tpl else: -- cgit v1.2.3