From 617d24b65edcf8b5b8948ee846efd2e94674bb8c Mon Sep 17 00:00:00 2001 From: Pierre Equoy Date: Tue, 5 Mar 2019 17:31:10 +0800 Subject: providers:checkbox: better handle unexpected times in sleep_time_check Sometimes, the time to sleep or resume cannot be computed accurately by FWTS. Instead of returning a numeric value, FWTS then returns "N/A". This commit handles this kind of case better. The job will fail (because it cannot calculate average time), but will provide clearer information instead of a scary stack trace. LP: #1816809 --- bin/sleep_time_check | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/bin/sleep_time_check b/bin/sleep_time_check index 9e7f084..f9513fa 100755 --- a/bin/sleep_time_check +++ b/bin/sleep_time_check @@ -41,12 +41,17 @@ def main(): resume_times = [] # find our times for line in lines: - if "Average time to sleep" in line: - sleep_time = float(line.split(':')[1].strip()) - sleep_times.append(sleep_time) - elif "Average time to resume" in line: - resume_time = float(line.split(':')[1].strip()) - resume_times.append(resume_time) + try: + if "Average time to sleep" in line: + sleep_time = float(line.split(':')[1].strip()) + sleep_times.append(sleep_time) + elif "Average time to resume" in line: + resume_time = float(line.split(':')[1].strip()) + resume_times.append(resume_time) + except ValueError as e: + print("ERROR: One or more times was not reported correctly:") + print(e) + return 1 if (sleep_time is None or resume_time is None) or \ (len(sleep_times) != len(resume_times)): -- cgit v1.2.3