6 files changed, 59 insertions, 6 deletions
diff --git a/src/clocktest.c b/src/clocktest.c
index 139056f..cc82d02 100644
--- a/src/clocktest.c
+++ b/src/clocktest.c
@@ -72,8 +72,8 @@ int test_clock_jitter(){
 #endif
 
 	if (jitter > MAX_JITTER || jitter < -MAX_JITTER){
- printf ("ERROR, jitter = %f\n",jitter);
- printf ("iter = %u, cpus = %u,%u\n",iter,slow_cpu,fast_cpu);
+ printf ("ERROR: jitter = %f Jitter must be < 0.2 to pass\n",jitter);
+ printf ("ERROR: Failed Iteration = %u, Slowest CPU: %u Fastest CPU: %u\n",iter,slow_cpu,fast_cpu);
 failures++;
 	}
 if (jitter > largest_jitter)
diff --git a/units/keys/jobs.pxu b/units/keys/jobs.pxu
index 8cef3e7..3b42f3e 100644
--- a/units/keys/jobs.pxu
+++ b/units/keys/jobs.pxu
@@ -290,6 +290,30 @@ _steps:
 _verification:
 Did the power management prompt pop up when press power button?
 
+plugin: user-interact
+category_id: com.canonical.plainbox::keys
+_summary:
+ Check power button event filtering
+id: keys/power-button-event
+estimated_duration: 15.0
+requires:
+ package.name == 'acpid'
+ package.name == 'libglib2.0-bin'
+command:
+ action=$(gsettings get org.gnome.settings-daemon.plugins.power power-button-action)
+ gsettings set org.gnome.settings-daemon.plugins.power power-button-action nothing
+ acpi_listen -t 10 | tee "$PLAINBOX_SESSION_SHARE"/power-button-event.log
+ gsettings set org.gnome.settings-daemon.plugins.power power-button-action "$action"
+ [[ $(grep -c "PBTN.*00000080" "$PLAINBOX_SESSION_SHARE"/power-button-event.log) -eq 1 ]] || \
+ [[ $(grep -c "PWRB.*00000080" "$PLAINBOX_SESSION_SHARE"/power-button-event.log) -eq 1 ]]
+purpose:
+ This test will check if power button event has reported correctly, the listener will
+ wait for 10 seconds.
+steps:
+ 1. Single press and release the power button in 10 seconds, some platforms might need long-press
+ to trigger the PBTN or PWRB event
+ 2. Check the number of output PBTN/PWRB event
+
 plugin: manual
 category_id: com.canonical.plainbox::keys
 id: keys/fn-lock
diff --git a/units/keys/test-plan.pxu b/units/keys/test-plan.pxu
index d4d2fe2..ffc111c 100644
--- a/units/keys/test-plan.pxu
+++ b/units/keys/test-plan.pxu
@@ -25,6 +25,7 @@ include:
 keys/keyboard-backlight certification-status=blocker
 keys/microphone-mute certification-status=blocker
 keys/power-button certification-status=blocker
+ keys/power-button-event certification-status=blocker
 keys/fn-lock certification-status=non-blocker
 
 id: keys-cert-automated
@@ -72,6 +73,7 @@ include:
 keys/keyboard-backlight certification-status=blocker
 keys/microphone-mute certification-status=blocker
 keys/power-button certification-status=blocker
+ keys/power-button-event certification-status=blocker
 
 id: after-suspend-keys-cert-blockers
 unit: test plan
diff --git a/units/touchpad/jobs.pxu b/units/touchpad/jobs.pxu
index 2fcdbc3..bb6f596 100644
--- a/units/touchpad/jobs.pxu
+++ b/units/touchpad/jobs.pxu
@@ -218,6 +218,36 @@ _siblings:
 [{ "id": "touchpad/continuous-move-after-suspend",
 "depends": "suspend/suspend_advanced touchpad/continuous-move" }]
 
+unit: template
+template-resource: device
+template-filter: device.category == 'TOUCHPAD'
+template-unit: job
+plugin: shell
+category_id: com.canonical.plainbox::touchpad
+id: touchpad/palm-rejection-firmware-labeling_{product_slug}
+requires: device.driver == 'hid-multitouch'
+estimated_duration: 5.0
+command:
+ abs_caps=$(cat </sys{path}/capabilities/abs)
+ abs_caps_hex=$((16#"$abs_caps"))
+ tool_type_bit=$((abs_caps_hex >> 55))
+ support=$((tool_type_bit & 1))
+ if [ $support -eq 1 ]; then
+ exit 0
+ else
+ echo "Touchapd info:"
+ cat </sys{path}/name
+ cat </sys{path}/modalias
+ echo "Touchpad EV_ABS capabilities:"
+ echo "$abs_caps"
+ exit 1
+ fi
+_summary: Touchpad EV_ABS capability check
+_description:
+ Libinput firmware/labeling palm detection rely on touchpad ABS_MT_TOOL_TYPE
+ capability. This test checks touchpad's EV_ABS capability to
+ make sure that firmware/labeling bit is set in touchpad firmware.
+
 id: touchpad/palm-rejection
 plugin: user-interact
 category_id: com.canonical.plainbox::touchpad
diff --git a/units/touchpad/test-plan.pxu b/units/touchpad/test-plan.pxu
index 188e7f2..39769d0 100644
--- a/units/touchpad/test-plan.pxu
+++ b/units/touchpad/test-plan.pxu
@@ -30,6 +30,7 @@ _description:
 Touchpad tests (Automated)
 include:
 touchpad/detected-as-mouse certification-status=blocker
+ touchpad/palm-rejection-firmware-labeling_.* certification-status=blocker
 
 
 id: after-suspend-touchpad-cert-full
diff --git a/units/wwan/jobs.pxu b/units/wwan/jobs.pxu
index aaa2089..de4b1bc 100644
--- a/units/wwan/jobs.pxu
+++ b/units/wwan/jobs.pxu
@@ -24,7 +24,6 @@ flags: preserve-locale also-after-suspend preserve-cwd
 imports: from com.canonical.plainbox import manifest
 requires:
 manifest.has_wwan_module == 'True'
- snap.name == 'core' and int(snap.revision) >= 1804 or package.name == 'modemmanager'
 snap.name == 'modem-manager' or package.name == 'modemmanager'
 
 unit: template
@@ -53,7 +52,6 @@ flags: preserve-locale also-after-suspend preserve-cwd
 imports: from com.canonical.plainbox import manifest
 requires:
 manifest.has_wwan_module == 'True'
- snap.name == 'core' and int(snap.revision) >= 1804 or package.name == 'modemmanager'
 snap.name == 'modem-manager' or package.name == 'modemmanager'
 
 unit: template
@@ -73,7 +71,6 @@ flags: preserve-locale also-after-suspend preserve-cwd
 imports: from com.canonical.plainbox import manifest
 requires:
 manifest.has_wwan_module == 'True'
- snap.name == 'core' and int(snap.revision) >= 1804 or package.name == 'modemmanager'
 snap.name == 'modem-manager' or package.name == 'modemmanager'
 
 unit: template
@@ -99,7 +96,6 @@ flags: preserve-locale also-after-suspend preserve-cwd
 imports: from com.canonical.plainbox import manifest
 requires:
 manifest.has_wwan_module == 'True'
- snap.name == 'core' and int(snap.revision) >= 1804 or package.name == 'modemmanager'
 snap.name == 'modem-manager' or package.name == 'modemmanager'
 
 id: wwan/detect-manual