summaryrefslogtreecommitdiff
diff options
authorPeter Sabaini <peter.sabaini@canonical.com>2021-01-20 16:26:55 +0100
committerPeter Sabaini <peter.sabaini@canonical.com>2021-01-20 16:26:55 +0100
commit3a03dc6b2aab6be1372edf7cbccd3513134fc914 (patch)
tree7286f45857a8d13ec1742153b5d738b33d79d796
parent731f08000d02fc78b64bc21fda4deceffc2173dd (diff)
Test fix
Fix unittests, update a reference string Also minor style updates
-rwxr-xr-xfiles/nrpe-external-master/check_replica_sets.py3
-rw-r--r--tests/unit/test_check_replica_sets.py2
2 files changed, 2 insertions, 3 deletions
diff --git a/files/nrpe-external-master/check_replica_sets.py b/files/nrpe-external-master/check_replica_sets.py
index 050f53d..f6d8feb 100755
--- a/files/nrpe-external-master/check_replica_sets.py
+++ b/files/nrpe-external-master/check_replica_sets.py
@@ -75,14 +75,13 @@ def get_replica_status():
# }
name = get_replica_set_name()
- if name is False:
+ if not name:
print("CRITIAL: unable to determine the replica set name")
sys.exit(NAGIOS_CRIT)
mongo_res = get_cmd_result(
["/usr/bin/mongo", name, "--quiet", "--eval", "JSON.stringify(rs.status())"]
)
- res_json = {}
try:
res_json = json.loads(mongo_res)
diff --git a/tests/unit/test_check_replica_sets.py b/tests/unit/test_check_replica_sets.py
index 274247b..5eb9b6e 100644
--- a/tests/unit/test_check_replica_sets.py
+++ b/tests/unit/test_check_replica_sets.py
@@ -169,7 +169,7 @@ class TestCheckReplicaSets(unittest.TestCase):
}"""
result = (
- "WARN: the following members are in non-core states: "
+ "WARN: the following members are in warning states: "
"two: RECOVERING, three: RECOVERING\n"
)
with mock.patch("sys.stdout", new=StringIO()) as fake_std_out: