| commit | 0405ec0719d25ab6cfc02a825b6f0a8704b6578c | [log] [tgz] |
|---|---|---|
| author | Thomas Draebing <thomas.draebing@sap.com> | Tue Feb 05 15:47:32 2019 +0100 |
| committer | Thomas Dräbing <thomas.draebing@sap.com> | Mon Feb 11 15:22:21 2019 +0000 |
| tree | 9ae25b82335a2eaaf9a88b2b5127da554700153c | |
| parent | d75fb7e45a0f0e6f422c4b6463afad98929fa0d1 [diff] |
Fix assembly of external id Two tests for the master-branch of the cfoauth-plugin failed: - testParseAccessTokenResponse - testGetAsAccessToken Both tests showed the same ComparisonFailure: expected:<external[:]marissa> but was:<external[]marissa> Since Commit 744d2b89 in Gerrit the scheme for external auth is defined without the trailing ':'. The colon however was expected by the cfoauth plugin, causing false assembly of the external id. This change adds the addition of a colon, when defining the external ID in the plugin code. Change-Id: If3d0cc52c0e64fb2b9cf3ce0a4b0774e9533da56
With this plugin Gerrit can use OAuth2 protocol to authenticate users accessing Gerrit's Web UI with a CloudFoundry User Account and Authentication (UAA) server. The Sign In link will redirect the user to the UAA login screen.
For Git-over-HTTP communication users still need to generate and use an HTTP password.
Apache License 2.0