| commit | ac88bd0fa8164d43be3e1d8319c1738219ece83a | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Mon May 01 23:42:15 2017 +0200 |
| committer | David Pursehouse <dpursehouse@collab.net> | Mon May 15 17:00:02 2017 +0900 |
| tree | 61ea1adbd729b5e8699a1e63fe3f686bfc84263e | |
| parent | ca826ec8de0bcae2fee35c3f4fc929f42b177761 [diff] |
PolyGerrit: Make ES6 to ES5 transpilation actually work Bump rules_closure version to this commit[1], that allows us to pass --force_inject_library=es6_runtime to closure compiler, that fixes missing injection of ES6 dependency with optimization level whitespace. One side effect of this change: because of the recently made change in rules_closure rules of how the external dependencies are consumed, we cannot reuse some common dependencies that were already fetched during gerrit build and must re-fetch them again, most notably: * asm * gson * guava * guice * soy The bad news here is, that re-fetching takes place with rules_closure's java_import_external rule, that is not using our own download_file.py utility and thus the artifacts are not cached in ~/.gerritcodereview directory, so that when the build is repeated on the same machine but on different clone of gerrit repository all rules_closure dependencies are going to be re-fetched again. Another complication of re-fetching is that the different versions of the artifacts are now fetched: e.g. Gerrit is using guava 21, and closure rule is using guava 20. The reason why we don't have the collision here is because gerrit mounts this dependency under @guava directory, whereas rules_closure is using canonical artifact name, so that we get: * external/com_google_guava/guava-20.0.jar # fetched by rules_closure * external/guava/jar/guava-21.0.jar # fetched by gerrit Test Plan: 1. conduct ES6 modification, e.g. apply this CL: [2] 2. run bazel build gerrit 3. verify that transpiled code actually work [1] https://github.com/bazelbuild/rules_closure/commit/f68d4b5a55c04ee50a3196590dce1ca8e7dbf438 [2] https://gerrit-review.googlesource.com/105104 Bug: Issue 6110 Change-Id: I3f3adf8ce5e613d45d1d0684b823e48e68a14080
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.