no-else-return

Disallow else blocks after return statements in if statements

🔧

Some problems reported by this rule are automatically fixable by the --fix command line option

❄️

This rule is currently frozen and is not accepting feature requests.

If an if block contains a return statement, the else block becomes unnecessary. Its contents can be placed outside of the block.

function foo() { if (x) { return y; } else { return z; } } 1
2
3
4
5
6
7

Rule Details

This rule is aimed at highlighting an unnecessary block of code following an if containing a return statement. As such, it will warn when it encounters an else following a chain of ifs, all of them containing a return statement.

Examples of incorrect code for this rule:

Open in Playground

/*eslint no-else-return: "error"*/ function foo1() { if (x) { return y; } else {  return z;  } } function foo2() { if (x) { return y; } else {  const t = "foo";  } } function foo3() { if (error) { return 'It failed'; } else {  if (loading) {  return "It's still loading";  }  } } // Two warnings for nested occurrences function foo4() { if (x) { if (y) { return y; } else {  return x;  } } else {  return z;  } } 1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40

Examples of correct code for this rule:

Open in Playground

/*eslint no-else-return: "error"*/ function foo1() { if (x) { return y; } return z; } function foo2() { if (x) { return y; } const t = "foo"; } function foo3() { if (error) { return 'It failed'; } if (loading) { return "It's still loading"; } } function foo4() { if (x) { if (y) { return y; } return x; } return z; } function foo5() { if (x) { const t = "foo"; } else { return y } } 1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47

Options

allowElseIf

This rule has an object option:

allowElseIf: true (default) - If true, allows else if blocks after a return

Examples of correct code for the default {"allowElseIf": true} option:

Open in Playground

/*eslint no-else-return: ["error", {allowElseIf: true}]*/ function foo() { if (error) { return 'It failed'; } else if (loading) { return "It's still loading"; } } // Using multiple `if` statements instead of `else if` is also allowed function foo2() { if (error) { return 'It failed'; } if (loading) { return "It's still loading"; } } 1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20

Examples of incorrect code for the {"allowElseIf": false} option:

Open in Playground

/*eslint no-else-return: ["error", {allowElseIf: false}]*/ function foo() { if (error) { return 'It failed'; } else if (loading) {  return "It's still loading";  } } 1
2
3
4
5
6
7
8
9

Examples of correct code for the {"allowElseIf": false} option:

Open in Playground

/*eslint no-else-return: ["error", {allowElseIf: false}]*/ function foo() { if (error) { return 'It failed'; } if (loading) { return "It's still loading"; } } 1
2
3
4
5
6
7
8
9
10
11

Version

This rule was introduced in ESLint v0.0.9.

Resources

Edit this page