Changeset 60907

Timestamp:

10/06/2025 11:44:48 PM (3 days ago)

Author:

westonruter

Message:

General: Optimize wp.sanitize.stripTags() to improve memory usage.

This updates the logic to use iteration instead of recursive calls, resulting in reduced memory usage and avoiding a possible stack overflow for large HTML documents.

The JS code is also tidied up with improved JSDoc and utilizing let instead of var.

Props jrchamp, sabernhardt, SirLouen, rollybueno, mukesh27, flixos90, westonruter.
Fixes #48054.

File:

• trunk/src/js/_enqueues/wp/sanitize.js (modified) (3 diffs)

trunk/src/js/_enqueues/wp/sanitize.js

@@ -2 +2 @@
  * @output wp-includes/js/wp-sanitize.js
  */
+
+/* eslint-env es6 */
 
 ( function () {
@@ -17 +19 @@
          * Strip HTML tags.
          *
-         * @param {string} text Text to strip the HTML tags from.
+         * @param {string} text - Text to strip the HTML tags from.
          *
-         * @return  Stripped text.
+         * @return {string} Stripped text.
          */
         stripTags: function( text ) {
-            text = text || '';
+            let _text = text || '';
 
-            // Do the replacement.
-            var _text = text
+            // Do the search-replace until there is nothing to be replaced.
+            do {
+                // Keep pre-replace text for comparison.
+                text = _text;
+
+                // Do the replacement.
+                _text = text
                     .replace( /<!--[\s\S]*?(-->|$)/g, '' )
                     .replace( /<(script|style)[^>]*>[\s\S]*?(<\/\1>|$)/ig, '' )
                     .replace( /<\/?[a-z][\s\S]*?(>|$)/ig, '' );
-
-            // If the initial text is not equal to the modified text,
-            // do the search-replace again, until there is nothing to be replaced.
-            if ( _text !== text ) {
-                return wp.sanitize.stripTags( _text );
-            }
+            } while ( _text !== text );
 
             // Return the text with stripped tags.
@@ -43 +45 @@
          * Strip HTML tags and convert HTML entities.
          *
-         * @param {string} text Text to strip tags and convert HTML entities.
+         * @param {string} text - Text to strip tags and convert HTML entities.
          *
-         * @return Sanitized text. False on failure.
+         * @return {string} Sanitized text.
          */
         stripTagsAndEncodeText: function( text ) {
-            var _text = wp.sanitize.stripTags( text ),
+            let _text = wp.sanitize.stripTags( text ),
                 textarea = document.createElement( 'textarea' );