Changeset 60654

Timestamp:

08/20/2025 02:59:41 PM (7 weeks ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Avoid an extra database query in WP_Post for a negative post ID.

Follow-up to [21559].

Props bor0, akeda, SergeyBiryukov.
Fixes #63850.

Location:

trunk

Files:

• src/wp-includes/class-wp-post.php (modified) (1 diff)
• tests/phpunit/tests/post/wpPost.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-post.php

@@ -234 +234 @@
 
         $post_id = (int) $post_id;
-        if ( ! $post_id ) {
+        if ( $post_id <= 0 ) {
             return false;
         }

trunk/tests/phpunit/tests/post/wpPost.php

@@ -43 +43 @@
 
     /**
+     * @ticket 63850
+     */
+    public function test_get_instance_should_not_perform_database_query_for_negative_number() {
+        $num_queries = get_num_queries();
+        $found       = WP_Post::get_instance( -self::$post_id );
+
+        $this->assertSame( $num_queries, get_num_queries() );
+    }
+
+    /**
      * @ticket 37738
      */